Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii): configure diagnostics in package.json #2233

Merged
merged 7 commits into from
Nov 9, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 6, 2020

Diagnostic codes and categories already exist in JSII. This change adds
configurability via package.json.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nija-at nija-at requested review from RomainMuller and a team November 6, 2020 17:58
@nija-at nija-at self-assigned this Nov 6, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2020
Niranjan Jayakar added 3 commits November 6, 2020 18:00
Diagnostic codes and categories already exist in JSII. This change adds
configurability via package.json.
@nija-at nija-at force-pushed the nija-at/configure-diagnostics branch from fe4f3eb to 4521e35 Compare November 6, 2020 18:00
packages/jsii/lib/jsii-diagnostic.ts Outdated Show resolved Hide resolved
packages/jsii/lib/jsii-diagnostic.ts Outdated Show resolved Hide resolved
packages/jsii/lib/project-info.ts Outdated Show resolved Hide resolved
@nija-at nija-at requested a review from RomainMuller November 9, 2020 10:57
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
  • Commit ID: f98c428
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller RomainMuller added the module/compiler Issues affecting the JSII compiler label Nov 9, 2020
@RomainMuller
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Command refresh: success

Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 9, 2020
@mergify mergify bot merged commit 2bbef1f into main Nov 9, 2020
@mergify mergify bot deleted the nija-at/configure-diagnostics branch November 9, 2020 17:07
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. module/compiler Issues affecting the JSII compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants