fix(pacmak): EMFILE error when running jsii-pacmak
#1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `findLocalBuildDirs` function did not have a protection against inspecting the same `package.json` file multiple times, and asynchronously traverses the whole dependency tree under the built package. In certain pathological cases, dependencies could be processed many times around (think about how `@aws-cdk/aws-iam` is a direct or transitive dependency of nearly every other `@aws-cdk/aws-*` module). The asynchronous nature of the process means that *many* instances of the same file could be opened at the same time, occasionally inching above the maximum file descriptor count limit, hence causing `EMFILE` ( which is the standard error code for "too many files open"). This change adds a `visitedDirectories` set to prevent re-visiting the same dependency instance multiple times (based on the absolute path of the package root). This incidentally also improves the performance of the process, since making promises incurs overhead, and not re-processing directories multiple times cut out a significant chunk of the promises made in extreme cases. Special thanks to @richardhboyd for having me look into this particular problem.
RomainMuller
added
bug
nija-at
reviewed
Aug 18, 2020
RomainMuller
force-pushed
the
rmuller/limit-fd-usage
branch
from
cea4368 to
9988142
Compare
RomainMuller
force-pushed
the
rmuller/limit-fd-usage
branch
from
9988142 to
0adfe53
Compare
MrArnoldPalmer
approved these changes
Aug 18, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findLocalBuildDirsfunction did not have a protection againstinspecting the same
package.jsonfile multiple times, andasynchronously traverses the whole dependency tree under the built
package. In certain pathological cases, dependencies could be processed
many times around (think about how
@aws-cdk/aws-iamis a direct ortransitive dependency of nearly every other
@aws-cdk/aws-*module).The asynchronous nature of the process means that many instances of
the same file could be opened at the same time, occasionally inching
above the maximum file descriptor count limit, hence causing
EMFILE(which is the standard error code for "too many files open").
This change adds a
visitedDirectoriesset to prevent re-visiting thesame dependency instance multiple times (based on the absolute path of
the package root). This incidentally also improves the performance of
the process, since making promises incurs overhead, and not
re-processing directories multiple times cut out a significant chunk of
the promises made in extreme cases.
Special thanks to @richardhboyd for having me look into this particular
problem.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.