Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii-pacmak): option to disallow parallel generation of languages #1890

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

RomainMuller
Copy link
Contributor

The build process for each language can be intensive in terms of limited resources,
such as open file handles. In certain environments, 'EMFILE' can happen as a result
of having ot many files concurrently open, failing the build. Limiting parallelism
can reduce (or effectively negate) the risk this happens.

The EMFILE problem was encountered by @richardhboyd.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The build process for each language can be intensive in terms of limited resources,
such as open file handles. In certain environments, 'EMFILE' can happen as a result
of having ot many files concurrently open, failing the build. Limiting parallelism
can reduce (or effectively negate) the risk this happens.
@RomainMuller RomainMuller requested a review from a team August 14, 2020 14:26
@RomainMuller RomainMuller self-assigned this Aug 14, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 17, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2020

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 002b37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9d5a439 into master Aug 17, 2020
@mergify mergify bot deleted the rmuller/no-parallel branch August 17, 2020 15:56
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants