Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii): Further normalize assembly outputs #177

Merged
merged 4 commits into from
Aug 14, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/codemaker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "tsc",
"watch": "tsc -w",
"build": "tsc -b",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s -b?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In full, --build. It's the new compiler mode that supports project references.

"watch": "tsc -b -w",
"test": "nodeunit test/test.*.js",
"package": "rm -fr dist/js && mkdir -p dist/js && mv $(npm pack) dist/js"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/codemaker/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"noUnusedLocals": true, /* Report errors on unused locals. */
"noUnusedParameters": true, /* Report errors on unused parameters. */
"noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
"noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
"composite": true, /* Allow this project to be referenced by others. */
}
}
4 changes: 2 additions & 2 deletions packages/jsii-calc-base-of-base/test/assembly.jsii
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"fingerprint": "I/HF4zJK5eV4ZLmNLDEzShkHVsxngX3K/y2SEYjXsxU=",
"author": {
"name": "Amazon Web Services",
"organization": true,
Expand Down Expand Up @@ -68,5 +67,6 @@
]
}
},
"version": "0.6.4"
"version": "0.6.4",
"fingerprint": "I/HF4zJK5eV4ZLmNLDEzShkHVsxngX3K/y2SEYjXsxU="
}
4 changes: 2 additions & 2 deletions packages/jsii-calc-base/test/assembly.jsii
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"fingerprint": "b+UZfT/No0vxqTQ1n3lIsyw7olqARDbeGj853lNFoE8=",
"author": {
"name": "Amazon Web Services",
"organization": true,
Expand Down Expand Up @@ -100,5 +99,6 @@
]
}
},
"version": "0.6.4"
"version": "0.6.4",
"fingerprint": "b+UZfT/No0vxqTQ1n3lIsyw7olqARDbeGj853lNFoE8="
}
24 changes: 12 additions & 12 deletions packages/jsii-calc-lib/test/assembly.jsii
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"fingerprint": "qwjIHOtTOSWOv5qzVdHj4SDgxmnWYsacVvR7BkAVlo8=",
"author": {
"name": "Amazon Web Services",
"organization": true,
Expand Down Expand Up @@ -125,20 +124,20 @@
"properties": [
{
"docs": {
"comment": "A string value"
"comment": "An awesome number value"
},
"name": "astring",
"name": "anumber",
"type": {
"primitive": "string"
"primitive": "number"
}
},
{
"docs": {
"comment": "An awesome number value"
"comment": "A string value"
},
"name": "anumber",
"name": "astring",
"type": {
"primitive": "number"
"primitive": "string"
}
},
{
Expand Down Expand Up @@ -187,20 +186,20 @@
"properties": [
{
"docs": {
"comment": "The number."
"comment": "The number multiplied by 2."
},
"immutable": true,
"name": "value",
"name": "doubleValue",
"type": {
"primitive": "number"
}
},
{
"docs": {
"comment": "The number multiplied by 2."
"comment": "The number."
},
"immutable": true,
"name": "doubleValue",
"name": "value",
"type": {
"primitive": "number"
}
Expand Down Expand Up @@ -315,5 +314,6 @@
]
}
},
"version": "0.6.4"
"version": "0.6.4",
"fingerprint": "MHdlbqyf1RV6moIHslfpKnl7yjQoYVvvZLfxFXWihrU="
}
Loading