Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): add explicit return type to setters #1645

Merged
merged 4 commits into from
May 11, 2020

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented May 11, 2020

Commit Message

feat(python): add explicit return type to setters (#1645)

Add an explicit -> None return annotation to generated property setter
methods. This makes the general style more consistent.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add an explicit `-> None` return annotation to generated property setter
methods. This makes the general style more consistent.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 11, 2020
@RomainMuller RomainMuller requested a review from a team May 11, 2020 11:50
@RomainMuller RomainMuller added the language/python Related to Python bindings label May 11, 2020
@RomainMuller RomainMuller self-assigned this May 11, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 9e8f77c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 7285baf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 24d1a0c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 11, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 11, 2020
@mergify
Copy link
Contributor

mergify bot commented May 11, 2020

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 8a1c512
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0f3c6e2 into master May 11, 2020
@mergify mergify bot deleted the rmuller/python-explicit-return-annotation branch May 11, 2020 19:34
@mergify
Copy link
Contributor

mergify bot commented May 11, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. language/python Related to Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants