feat(submodules): allow python submodule name configuration #1502
Conversation
Using a `.jsiirc.json` file, the name generation for entities within a submodule can be configured ot use a different name than the default.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| ) | ||
| from .deeply_nested import ( | ||
| INamespaced as _INamespaced_e2f386ad, | ||
| ) | ||
| import scope.jsii_calc_base | ||
| import scope.jsii_calc_base_of_base | ||
| import scope.jsii_calc_lib | ||
|
|
||
| __jsii_assembly__ = jsii.JSIIAssembly.load("jsii-calc", "0.0.0", "jsii_calc", "[email protected]") |
There was a problem hiding this comment.
Are you planning to also fix #1501 as part of this commit (i.e. always import the root module so you can use __name__ instead of an explicit name in the .load() call?
There was a problem hiding this comment.
I've actually fixed it separately because this would land too late.
| venv="${outdir}/.env" | ||
| python3 -m venv ${venv} | ||
| . ${venv}/bin/activate | ||
| pip install pip~=20.0.2 setuptools~=46.1.3 wheel~=0.34.2 twine~=3.1.1 |
There was a problem hiding this comment.
Where do these version numbers come from?
There was a problem hiding this comment.
THey're the "latest" from pypi. Just some housekeeping since those aren't managed by dependabot.
| { | ||
| "targets": { | ||
| "java": { | ||
| "package": "software.amazon.jsii.tests.calculator.refers_to_parent" |
There was a problem hiding this comment.
Is the plan to also support java and .net in this PR or as a separate PR?
There was a problem hiding this comment.
I was thinking probably subsequent PR, not settled yet.
| * | ||
| * @default none | ||
| */ | ||
| submodules?: { [name: string]: AssemblyConfiguration }; |
There was a problem hiding this comment.
Requires updating the spec document, no?
There was a problem hiding this comment.
Hence this is a draft PR at this point :)
| @@ -1168,3 +1168,8 @@ def test_collection_of_interfaces_map_of_structs(): | |||
| def test_collection_of_interfaces_map_of_interfaces(): | |||
| for elt in InterfaceCollections.map_of_interfaces().values(): | |||
| assert getattr(elt, "ring") is not None | |||
|
|
|||
| def test_load_submodules(): | |||
There was a problem hiding this comment.
Do we also want to verify that they can be loaded out of order?
| private readonly _submoduleMap = new Map<ts.Symbol, ts.Symbol>(); | ||
| private readonly _submodules = new Set<ts.Symbol>(); | ||
| // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility | ||
| readonly #submoduleMap = new Map<ts.Symbol, ts.Symbol>(); |
There was a problem hiding this comment.
Another important requirement which I hope we can include in this PR: we need to be able to provide an alternative name in each language for types in the root namespace as well.
In monocdk we publish the core types (e.g. App, Stack) under the root namespace, but in e.g. java, those are available under software.amazon.awscdk.core.App.
Copy @MrArnoldPalmer
|
@eladb - can't you just make monocdk's root Java package be |
I guess you are right. @MrArnoldPalmer can you acknowledge that you saw this discussion? |
|
I'm dropping this PR because it'll be superceded by a different (and I believe slightly simpler) way to model the data in the Assembly schema. |
Using a
.jsiirc.jsonfile, the name generation for entities within asubmodule can be configured ot use a different name than the default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.