Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rosetta): inline functions in objects should be disallowed #3061

Closed
rix0rrr opened this issue Oct 12, 2021 · 1 comment · Fixed by #3065
Closed

(rosetta): inline functions in objects should be disallowed #3061

rix0rrr opened this issue Oct 12, 2021 · 1 comment · Fixed by #3065
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 12, 2021

🐛 Bug Report

From https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/aws-s3-assets

new assets.Asset(this, 'BundledAsset', {
  path: '/path/to/asset',
  bundling: {
    local: {
      tryBundle(outputDir: string, options: BundlingOptions) {
        if (canRunLocally) {
          // perform local bundling here
          return true;
        }
        return false;
      },
    },
    // Docker bundling fallback
    image: DockerImage.fromRegistry('alpine'),
    entrypoint: ['/bin/sh', '-c'],
    command: ['bundle'],
  },
});

Cannot work.

@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2021
rix0rrr added a commit that referenced this issue Oct 13, 2021
We'll report on anything else that JavaScript allows you to do (methods, getters, etc).

Fixes #3061.
@mergify mergify bot closed this as completed in #3065 Oct 13, 2021
mergify bot pushed a commit that referenced this issue Oct 13, 2021
We'll report on anything else that JavaScript allows you to do (methods, getters, etc).

Fixes #3061.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant