Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rosetta) Should not accept ?? operator #3053

Closed
rix0rrr opened this issue Oct 11, 2021 · 1 comment · Fixed by #3060
Closed

(rosetta) Should not accept ?? operator #3053

rix0rrr opened this issue Oct 11, 2021 · 1 comment · Fixed by #3060
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 11, 2021

🐛 Bug Report

Cannot be properly translated into all languages, so we should disallow it.
@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 11, 2021
rix0rrr added a commit that referenced this issue Oct 12, 2021
@rix0rrr
fix(rosetta): disallow ?? operator in examples
e76d23a 
It cannot be translated, and so should be written as an `if` statement
or a ternary.

Fixes #3053.
@rix0rrr rix0rrr mentioned this issue Oct 12, 2021
Merged
@mergify mergify bot closed this as completed in #3060 Oct 13, 2021
mergify bot pushed a commit that referenced this issue Oct 13, 2021
@rix0rrr
fix(rosetta): disallow nullish coalescing operator in examples (#3060)
a35bbfa 
It cannot be translated, and so should be written as an `if` statement
or a ternary.

Fixes #3053.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rosetta): disallow nullish coalescing operator in examples aws/jsii
1 participant
@rix0rrr