pacmak: go build does not build submodule directories #2618
Assignees
Labels
Comments
eladb
added
bug
eladb
pushed a commit
that referenced
this issue
Feb 28, 2021
The `go build` command we run during pacmak did not descend into submodules. After adding `./...` to the `go build` command, a few other issues were surfaced related to static member handling. The common issue was that `GoClass` had two separate lists (for static and non-static methods/props). This caused various places in the implementation to only take into account non-static members. Added a new list called `members` which collected both static and non-static members and used it in the various dependency props. An empty module in Python (with only submodules) will result in an empty `__all__` list which yields a MyPy error. Fixes #2618 - go build does not build submodule directories Fixes #2619 - go/python module with only submodules (no direct types) fails compilation Fixes #2620 - go missing imports if class includes only static members Fixes #2621 - invalid go imports when types referenced by static members
eladb
pushed a commit
that referenced
this issue
Mar 1, 2021
The `go build` command we run during pacmak did not descend into submodules. After adding `./...` to the `go build` command, a few other issues were surfaced related to static member handling. The common issue was that `GoClass` had two separate lists (for static and non-static methods/props). This caused various places in the implementation to only take into account non-static members. Added a new list called `members` which collected both static and non-static members and used it in the various dependency props. An empty module in Python (with only submodules) will result in an empty `__all__` list which yields a MyPy error. Fixes #2618 - go build does not build submodule directories Fixes #2619 - go/python module with only submodules (no direct types) fails compilation Fixes #2620 - go missing imports if class includes only static members Fixes #2621 - invalid go imports when types referenced by static members
|
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
Affected Languages
GolangTypeScriptorJavascriptPythonJavaC#,F#, ...)General Information
What is the problem?
When pacmak runs
go buildit will only build the root module and any submodules referenced by it, but if there is no reference it won't recursive into submodule directories.We need to run
go build ./...to do that.Verbose Log
The text was updated successfully, but these errors were encountered: