Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.16 breaks go pacmak #2615

Closed
eladb opened this issue Feb 28, 2021 · 1 comment · Fixed by #2616, cdk8s-team/cdk8s-operator#228 or awslabs/aws-delivlib-sample#83
Closed

go 1.16 breaks go pacmak #2615

eladb opened this issue Feb 28, 2021 · 1 comment · Fixed by #2616, cdk8s-team/cdk8s-operator#228 or awslabs/aws-delivlib-sample#83
Assignees

Comments

@eladb
Copy link
Contributor

eladb commented Feb 28, 2021

Starting go 1.16, go build will not update go.sum automatically and requires that users explicitly execute go mod download.

Since jsii/superchain now includes go 1.16 instead of 1.15, pacmak is now failing to create go bindings with the following error:

go: github.com/aws/[email protected]: missing go.sum entry; to add it:
 	go mod download github.com/aws/jsii-runtime-go

To address, we need to run go mod download before we run go build.

@eladb eladb self-assigned this Feb 28, 2021
@eladb eladb removed their assignment Feb 28, 2021
@eladb eladb changed the title Disable sumdb and proxy when building go bindings go 1.16 breaks go pacmak Feb 28, 2021
@eladb eladb self-assigned this Feb 28, 2021
eladb pushed a commit that referenced this issue Feb 28, 2021
Starting go 1.16, `go build` does not download modules and updates go.sum automatically. To that end, we now execute this before we execute `go build` during pacmak.

Additionally, set `GOSUMDB` to `off` in order to reduce the chance for eventual consistency issues when new modules are published.

Fixes #2615
eladb pushed a commit that referenced this issue Feb 28, 2021
…2616)

Starting go 1.16, `go build` does not download modules and updates go.sum automatically. To that end, we now execute this before we execute `go build` during pacmak.

Additionally, set `GOSUMDB` to `off` in order to reduce the chance for eventual consistency issues when new modules are published.

Fixes #2615
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment