Identical static methods in parent/child classes are mistakenly marked as overrides in java resulting in a compilation error

[iliapolo]

🐛 Bug Report

Affected Languages

• TypeScript or Javascript
• Python
• Java
• .NET (C#, F#, ...) [Probably]

General Information

• JSII Version: 1.15.0 (build 585166b), typescript 3.9.7
• Platform: MacOS, CodeBuild (jsii/superchain)

What is the problem?

We encountered a scenario in aws-cdk that generates illegal java code, annotating static methods with the @Override annotation.

This happens when a child class has the same static method as its parent.

export class Parent {
  public static hello() {}
}

export class Child extends Parent {
  public static hello() {}
}

This code will generate a JSII assembly that marks the Child.hello function both as static and as overrides of Parent.hello.
The generated java code will look like:

public class Child extends Parent {

  @Override
  public static hello() {}

}

Resulting in a compilation error: method does not override or implement a method from a supertype

See aws/aws-cdk#12091 for the full scenario.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.