Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go module file generation #2090

Closed
MrArnoldPalmer opened this issue Oct 8, 2020 · 1 comment · Fixed by #2265
Closed

Go module file generation #2090

MrArnoldPalmer opened this issue Oct 8, 2020 · 1 comment · Fixed by #2265
Assignees
@MrArnoldPalmer @SoManyHs
Labels
effort/medium Medium work item – a couple days of effort feature-request A feature should be added or improved. language/go Regarding GoLang bindings
Milestone
GoLang Alpha

Comments

@MrArnoldPalmer
Copy link
Contributor

MrArnoldPalmer commented Oct 8, 2020 •
edited by SoManyHs
Loading

jsii-pacmak currently doesn't output go.mod files for generated go modules. This relies on users to write their own module definition files based on the structure of their output directory.

Each package should generate a go.mod file next to the root package source file. The go.mod file should declare a dependency on the JSII runtime (with the same version of the jsii-pacmak being run to do the output). It should also declare dependencies on each of the JSII modules that it uses. Each of these dependencies is available in the .jsii assembly and the version for each in go.mod should match what is provided there.

Example of expected file structure:

<root>
 ┗━ 📁 go
    ┗━ 📁 scopejsiicalcbase
       ┣━ 📁 jsii
       ┃  ┣━ 📄 jsii.go
       ┃  ┗━ 📄 tarball.embedded.go
       ┣━ 📁 scopejsiicalcbase.go
       ┗━ 📄 go.mod
@MrArnoldPalmer MrArnoldPalmer added language/go Regarding GoLang bindings feature-request A feature should be added or improved. effort/medium Medium work item – a couple days of effort labels Oct 8, 2020
@SoManyHs SoManyHs self-assigned this Oct 27, 2020
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Nov 19, 2020
@SoManyHs
chore: generate go.mod fileso
dd172fb 
Closes aws#2090
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Nov 19, 2020
@SoManyHs
chore: generate go.mod files
d1b30b4 
Closes aws#2090
@SoManyHs SoManyHs mentioned this issue Nov 19, 2020
Merged
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Nov 19, 2020
@SoManyHs
chore: generate go.mod files
ba6c92c 
Closes aws#2090
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Nov 19, 2020
@SoManyHs
chore: generate go.mod files
9485d25 
Closes aws#2090
SoManyHs added a commit to SoManyHs/jsii that referenced this issue Nov 19, 2020
@SoManyHs
chore: generate go.mod files
a61358b 
Closes aws#2090
@SomayaB SomayaB added the in-progress Issue is being actively worked on. label Nov 20, 2020
RomainMuller pushed a commit that referenced this issue Nov 20, 2020
@SoManyHs @MrArnoldPalmer
feat(go): generate go.mod files (#2265)
4164eb5 
Closes #2090

Co-authored-by: Valine <[email protected]>
Co-authored-by: Mitchell Valine <[email protected]>
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@SoManyHs SoManyHs removed the in-progress Issue is being actively worked on. label Nov 20, 2020
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Nov 20, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

@SoManyHs SoManyHs

Labels
effort/medium Medium work item – a couple days of effort feature-request A feature should be added or improved. language/go Regarding GoLang bindings
Projects
None yet
Milestone
GoLang Alpha
Development

Successfully merging a pull request may close this issue.

feat(go): generate go.mod files SoManyHs/jsii
3 participants
@MrArnoldPalmer @SomayaB @SoManyHs