feat(jsii): prohibit changing visibility when overriding #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since C# does not allow changing the visibility of a member when overriding it, added a check to ensure nobody attempts to make a protected member public when overriding it. This is a somewhat common pitfall for users (as seen for example in aws/aws-cdk#9616), and the check will allow faster detection and correction (i.e: at compilation time instead of during `jsii-pacmak`).
RomainMuller
added
feature-request
RomainMuller
changed the title
rix0rrr
approved these changes
Aug 12, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
deleted the
rmuller/prohibit-visibility-changes-in-overrides
branch
skorfmann
added a commit
to hashicorp/terraform-cdk
that referenced
this pull request
Aug 19, 2020
In the recent Jsii release https://github.com/aws/jsii/releases/tag/v1.11.0 a detection for changing visibility when overriding was added aws/jsii#1876 and prevents it from building.
anubhavmishra
pushed a commit
to hashicorp/terraform-cdk
that referenced
this pull request
Aug 20, 2020
* Don't change visibility for "synthesizeAttributes" In the recent Jsii release https://github.com/aws/jsii/releases/tag/v1.11.0 a detection for changing visibility when overriding was added aws/jsii#1876 and prevents it from building. * Update snapshots to reflect the changed visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since C# does not allow changing the visibility of a member when
overriding it, added a check to ensure nobody attempts to make a
protected member public when overriding it.
This is a somewhat common pitfall for users (as seen for example in
aws/aws-cdk#9616), and the check will allow faster detection and
correction (i.e: at compilation time instead of during
jsii-pacmak).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.