Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build aws-cdk as an integration test for jsii #1209

Closed
RomainMuller opened this issue Jan 21, 2020 · 1 comment · Fixed by #1219
Closed

Build aws-cdk as an integration test for jsii #1209

RomainMuller opened this issue Jan 21, 2020 · 1 comment · Fixed by #1219
Assignees
@MrArnoldPalmer
Labels
feature-request A feature should be added or improved. ops-excellence Operational Excellence

Comments

@RomainMuller
Copy link
Contributor

As a way to identify testing gap in jsii.
@RomainMuller RomainMuller added ops-excellence Operational Excellence feature-request A feature should be added or improved. labels Jan 21, 2020
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Jan 21, 2020
Closed
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 27, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
72ae2c5 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 27, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
4d83bcd 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 27, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
437c804 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 27, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
5296985 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Jan 27, 2020
Merged
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 29, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
5fa8b18 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Jan 29, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
dbdc1ac 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Feb 3, 2020
Merged
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Feb 10, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
88d4d4e 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit to MrArnoldPalmer/jsii that referenced this issue Feb 14, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test
59f34c0 
Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: aws#1209
MrArnoldPalmer added a commit that referenced this issue Feb 14, 2020
@MrArnoldPalmer
feat: CDK Build Integration Test (#1219)
e99d722 
* feat: CDK Build Integration Test

Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: #1209
@eladb
Copy link
Contributor

eladb commented Feb 16, 2020

Yey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
feature-request A feature should be added or improved. ops-excellence Operational Excellence
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CDK Build Integration Test MrArnoldPalmer/jsii
3 participants
@RomainMuller @eladb @MrArnoldPalmer