revert: "fix(dotnet): strong-name sign assemblies (#2894)" (#2902)

This reverts commit 7b90f27, and removes all support for .NET Strong-Name Signing, as this would be impossible to use as long as the `Amazon.Jsii.Runtime` assembly is not strong-name signed itself (which would be a breaking change to do!), since strong-name signed assemblies can only depend on other strong-name signed assemblies.
aws · Jul 9, 2021 · 0006aee · 0006aee
1 parent e05ce62
commit 0006aee
Show file tree

Hide file tree

Showing 38 changed files with 19 additions and 246 deletions.
diff --git a/.gitignore b/.gitignore
@@ -10,3 +10,4 @@ dist/
 *.tsbuildinfo
 *.tabl.json
 *.swp
+*.snk
diff --git a/gh-pages/content/user-guides/lib-author/configuration/targets/dotnet.md b/gh-pages/content/user-guides/lib-author/configuration/targets/dotnet.md
@@ -8,9 +8,6 @@ The `dotnet` target requires the following configuration:
   transparent background is recommended. See the [.NET documentation] for more information.
 - `versionSuffix` - an optional suffix that will be appended at the end of the NuGet package's `version` field. The
   suffix must start with a `-`.
-- `signAssembly` - whether the assembly should be strong-name signed. Defaults to `false` when not specified.
-- `assemblyOriginatorKeyFile`- the path to the strong-name signing key to be used. When not specified or if the file
-  referred to does not exist, the assembly will not be strong-name signed.
 
 Example:
 
@@ -21,8 +18,6 @@ Example:
       "namespace": "Acme.HelloJsii",              // Required
       "packageId": "Acme.HelloJsii",              // Required
       "iconUrl": "https://cdn.acme.com/icon.png", // Optional
-      "signAssembly": true,                       // Optional
-      "assemblyOriginatorKeyFile": "./key.snk",   // Optional
       "versionSuffix": "-preview"                 // Optional
     },
     // ...

diff --git a/...est/test/Amazon.JSII.Runtime.IntegrationTests/Amazon.JSII.Runtime.IntegrationTests.csproj b/...est/test/Amazon.JSII.Runtime.IntegrationTests/Amazon.JSII.Runtime.IntegrationTests.csproj
@@ -13,9 +13,6 @@
         <VSTestLogger>xunit</VSTestLogger>
 
         <RollForward>Major</RollForward>
-
-        <SignAssembly>true</SignAssembly>
-        <AssemblyOriginatorKeyFile>..\..\..\dotnet-runtime\keypair.snk</AssemblyOriginatorKeyFile>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/...st/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId/keypair.snk b/...st/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId/keypair.snk
diff --git a/...est/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.BasePackageId/keypair.snk b/...est/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.BasePackageId/keypair.snk
diff --git a/...test/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.LibPackageId/keypair.snk b/...test/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId.LibPackageId/keypair.snk
diff --git a/...tnet-runtime-test/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId/keypair.snk b/...tnet-runtime-test/test/generated/dotnet/Amazon.JSII.Tests.CalculatorPackageId/keypair.snk
diff --git a/packages/@jsii/dotnet-runtime/NuGet.Metadata.props.t.js b/packages/@jsii/dotnet-runtime/NuGet.Metadata.props.t.js
@@ -20,9 +20,6 @@ process.stdout.write(`<Project>
     <IncludeSource>True</IncludeSource>
 
     <PackageOutputPath>..\\..\\bin\\$(Configuration)\\NuGet\\</PackageOutputPath>
-
-    <AssemblyOriginatorKeyFile>key.snk</AssemblyOriginatorKeyFile>
-    <SignAssembly Condition="Exists('$(AssemblyOriginatorKeyFile)')">True</SignAssembly>
   </PropertyGroup>
 </Project>
 `);
diff --git a/packages/@jsii/dotnet-runtime/keypair.snk b/packages/@jsii/dotnet-runtime/keypair.snk
diff --git a/...dotnet-runtime/src/Amazon.JSII.Analyzers.UnitTests/Amazon.JSII.Analyzers.UnitTests.csproj b/...dotnet-runtime/src/Amazon.JSII.Analyzers.UnitTests/Amazon.JSII.Analyzers.UnitTests.csproj
@@ -12,9 +12,6 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 
     <RollForward>Major</RollForward>
-
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>..\..\keypair.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Analyzers/Amazon.JSII.Analyzers.csproj b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Analyzers/Amazon.JSII.Analyzers.csproj
@@ -10,9 +10,6 @@
 
         <EnableNETAnalyzers>true</EnableNETAnalyzers>
         <AnalysisMode>AllEnabledByDefault</AnalysisMode>
-
-        <SignAssembly>true</SignAssembly>
-        <AssemblyOriginatorKeyFile>..\..\keypair.snk</AssemblyOriginatorKeyFile>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.JsonModel/Amazon.JSII.JsonModel.csproj b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.JsonModel/Amazon.JSII.JsonModel.csproj
@@ -12,9 +12,6 @@
 
     <Nullable>enable</Nullable>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>..\..\keypair.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/...sii/dotnet-runtime/src/Amazon.JSII.Runtime.UnitTests/Amazon.JSII.Runtime.UnitTests.csproj b/...sii/dotnet-runtime/src/Amazon.JSII.Runtime.UnitTests/Amazon.JSII.Runtime.UnitTests.csproj
@@ -18,9 +18,6 @@
       CA1711, <!-- Identifiers should not have incorrect suffix -->
       CA1724, <!-- Type names should not match namespaces -->
     </NoWarn>
-
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>..\..\keypair.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime.UnitTests/JsonModel/AssemblyTests.cs b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime.UnitTests/JsonModel/AssemblyTests.cs
@@ -37,8 +37,6 @@ public void ShouldSerializeAllMembers()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     dependencies: new Dictionary<string, PackageVersion>(),
@@ -92,8 +90,6 @@ public void ShouldSerializeAllMembers()
     ""dotnet"": {
       ""namespace"": ""Dot.Net.Namespace"",
       ""packageId"": ""Dot.Net.PackageId"",
-      ""signAssembly"": true,
-      ""assemblyOriginatorKeyFile"": ""key.snk"",
       ""iconUrl"": ""http://www.example.com/icon.png""
     }
   }
@@ -120,8 +116,6 @@ public void ShouldThrowOnMissingName()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     dependencies: new Dictionary<string, PackageVersion>(),
@@ -149,8 +143,6 @@ public void ShouldThrowOnMissingVersion()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     types: new Dictionary<string, Amazon.JSII.JsonModel.Spec.Type>(),
@@ -176,8 +168,6 @@ public void ShouldNotSerializeMissingDependencies()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     types: new Dictionary<string, Amazon.JSII.JsonModel.Spec.Type>(),
@@ -210,8 +200,6 @@ public void ShouldNotSerializeMissingDependencies()
     ""dotnet"": {
       ""namespace"": ""Dot.Net.Namespace"",
       ""packageId"": ""Dot.Net.PackageId"",
-      ""signAssembly"": true,
-      ""assemblyOriginatorKeyFile"": ""key.snk"",
       ""iconUrl"": ""http://www.example.com/icon.png""
     }
   }
@@ -236,8 +224,6 @@ public void ShouldNotSerializeMissingBundled()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     types: new Dictionary<string, Amazon.JSII.JsonModel.Spec.Type>(),
@@ -270,8 +256,6 @@ public void ShouldNotSerializeMissingBundled()
     ""dotnet"": {
       ""namespace"": ""Dot.Net.Namespace"",
       ""packageId"": ""Dot.Net.PackageId"",
-      ""signAssembly"": true,
-      ""assemblyOriginatorKeyFile"": ""key.snk"",
       ""iconUrl"": ""http://www.example.com/icon.png""
     }
   }
@@ -296,8 +280,6 @@ public void ShouldNotSerializeMissingDocs()
                     targets: new AssemblyTargets(new AssemblyTargets.DotNetTarget(
                         @namespace: "Dot.Net.Namespace",
                         packageId: "Dot.Net.PackageId",
-                        signAssembly: true,
-                        assemblyOriginatorKeyFile: "key.snk",
                         iconUrl: "http://www.example.com/icon.png"
                     )),
                     types: new Dictionary<string, Amazon.JSII.JsonModel.Spec.Type>(),
@@ -330,8 +312,6 @@ public void ShouldNotSerializeMissingDocs()
     ""dotnet"": {
       ""namespace"": ""Dot.Net.Namespace"",
       ""packageId"": ""Dot.Net.PackageId"",
-      ""signAssembly"": true,
-      ""assemblyOriginatorKeyFile"": ""key.snk"",
       ""iconUrl"": ""http://www.example.com/icon.png""
     }
   }
@@ -429,8 +409,6 @@ public void ShouldDeserializeAllMembersWithDotNetTarget()
     ""dotnet"": {
       ""namespace"": ""Dot.Net.Namespace"",
       ""packageId"": ""Dot.Net.PackageId"",
-      ""signAssembly"": true,
-      ""assemblyOriginatorKeyFile"": ""key.snk"",
       ""iconUrl"": ""http://www.example.com/icon.png""
     },
     ""java"": { ""package"": ""com.amazonaws.cdk.Test"" }
@@ -463,8 +441,6 @@ public void ShouldDeserializeAllMembersWithDotNetTarget()
                 Assert.NotNull(dotNetTarget);
                 Assert.Equal("Dot.Net.Namespace", dotNetTarget?.Namespace);
                 Assert.Equal("Dot.Net.PackageId", dotNetTarget?.PackageId);
-                Assert.True(dotNetTarget?.SignAssembly);
-                Assert.Equal("key.snk", dotNetTarget?.AssemblyOriginatorKeyFile);
                 Assert.Equal("http://www.example.com/icon.png", dotNetTarget?.IconUrl);
 
                 Assert.Equal("myVersion", actual.Version, ignoreLineEndingDifferences: true);

diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/Amazon.JSII.Runtime.csproj b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/Amazon.JSII.Runtime.csproj
@@ -28,17 +28,13 @@
       CA1819, <!-- Properties should not return arrays -->
       CA2225, <!-- Operator overloads have named alternates -->
     </NoWarn>
-
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>..\..\keypair.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" />
     <PackageReference Include="Microsoft.Extensions.Logging" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" />
     <PackageReference Include="Newtonsoft.Json" />
-    <PackageReference Include="NSubstitute" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/AssemblyInfo.cs b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/AssemblyInfo.cs
@@ -1,9 +1,8 @@
-using Castle.Core.Internal;
 using System;
 using System.Runtime.CompilerServices;
 
 [assembly:CLSCompliant(false)] // among other things, array parameters are passed to attributes
 
-[assembly:InternalsVisibleTo("Amazon.JSII.Runtime.IntegrationTests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d7206fa09e081f23fa91938ceede7b25c0dfb8010fa55038a859a3e0150f652e655b8f0d9c17c41bb1d2b2c5ee2eb6af43a930cd8e80c2d7fe7703b24e66a1c674f6328e44bda8000b5df4686d77be2aeef092da587672a7ca9b9a9502ad960bcb7f35154d9a855bf9db546daf79a34c9fb5ecb23c6291a92587d8ece0354e9c")]
-[assembly:InternalsVisibleTo("Amazon.JSII.Runtime.UnitTests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100d7206fa09e081f23fa91938ceede7b25c0dfb8010fa55038a859a3e0150f652e655b8f0d9c17c41bb1d2b2c5ee2eb6af43a930cd8e80c2d7fe7703b24e66a1c674f6328e44bda8000b5df4686d77be2aeef092da587672a7ca9b9a9502ad960bcb7f35154d9a855bf9db546daf79a34c9fb5ecb23c6291a92587d8ece0354e9c")]
-[assembly:InternalsVisibleTo(InternalsVisible.ToDynamicProxyGenAssembly2)]
+[assembly:InternalsVisibleTo("Amazon.JSII.Runtime.IntegrationTests")]
+[assembly:InternalsVisibleTo("Amazon.JSII.Runtime.UnitTests")]
+[assembly:InternalsVisibleTo("DynamicProxyGenAssembly2")]
diff --git a/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/JsonModel/Spec/AssemblyTargets.cs b/packages/@jsii/dotnet-runtime/src/Amazon.JSII.Runtime/JsonModel/Spec/AssemblyTargets.cs
@@ -23,8 +23,6 @@ public DotNetTarget
                 string @namespace,
                 string packageId,
                 string? title = null,
-                bool signAssembly = false,
-                string? assemblyOriginatorKeyFile = null,
                 string? iconUrl = null,
                 string? versionSuffix = null
             )
@@ -33,8 +31,6 @@ public DotNetTarget
                 PackageId = packageId ?? throw new ArgumentNullException(nameof(packageId));
 
                 Title = title;
-                SignAssembly = signAssembly;
-                AssemblyOriginatorKeyFile = assemblyOriginatorKeyFile;
                 IconUrl = iconUrl;
                 VersionSuffix = versionSuffix;
 
@@ -53,12 +49,6 @@ public DotNetTarget
             [JsonProperty("title", NullValueHandling = NullValueHandling.Ignore)]
             public string? Title { get; }
 
-            [JsonProperty("signAssembly", NullValueHandling = NullValueHandling.Ignore)]
-            public bool SignAssembly { get; }
-
-            [JsonProperty("assemblyOriginatorKeyFile", NullValueHandling = NullValueHandling.Ignore)]
-            public string? AssemblyOriginatorKeyFile { get; }
-
             [JsonProperty("iconUrl", NullValueHandling = NullValueHandling.Ignore)]
             public string? IconUrl { get; }
 

diff --git a/packages/@jsii/kernel/test/kernel.test.ts b/packages/@jsii/kernel/test/kernel.test.ts
@@ -387,12 +387,10 @@ defineTest(
   (sandbox) => {
     expect(sandbox.naming({ assembly: 'jsii-calc' }).naming).toEqual({
       dotnet: {
-        assemblyOriginatorKeyFile: 'keypair.snk',
         iconUrl:
           'https://sdk-for-net.amazonwebservices.com/images/AWSLogo128x128.png',
         namespace: 'Amazon.JSII.Tests.CalculatorNamespace',
         packageId: 'Amazon.JSII.Tests.CalculatorPackageId',
-        signAssembly: true,
       },
       go: {
         moduleName: 'github.com/aws/jsii/jsii-calc/go',
@@ -414,11 +412,9 @@ defineTest(
     expect(sandbox.naming({ assembly: '@scope/jsii-calc-lib' }).naming).toEqual(
       {
         dotnet: {
-          assemblyOriginatorKeyFile: 'keypair.snk',
           namespace: 'Amazon.JSII.Tests.CalculatorNamespace.LibNamespace',
           packageId: 'Amazon.JSII.Tests.CalculatorPackageId.LibPackageId',
           versionSuffix: '-devpreview',
-          signAssembly: true,
         },
         go: {
           moduleName: 'github.com/aws/jsii/jsii-calc/go',
@@ -2211,7 +2207,7 @@ async function preparePackage(module: string, useCache = true) {
   }
 
   const packageRoot = findPackageRoot(module);
-  await new Promise<void>((ok, ko) => {
+  await new Promise((ok, ko) => {
     const child = childProcess.spawn('npm', ['pack', packageRoot], {
       cwd: staging,
       shell: true,

diff --git a/packages/@jsii/spec/lib/configuration.ts b/packages/@jsii/spec/lib/configuration.ts
@@ -77,16 +77,6 @@ export interface Config {
        * version field
        */
       versionSuffix?: string;
-
-      /**
-       * whether the assembly should be strong-name signed
-       */
-      signAssembly?: boolean;
-
-      /**
-       * path to the strong-name signing key to be used
-       */
-      assemblyOriginatorFile?: string;
     };
   };
 

diff --git a/packages/@scope/jsii-calc-base-of-base/keypair.snk b/packages/@scope/jsii-calc-base-of-base/keypair.snk
diff --git a/packages/@scope/jsii-calc-base-of-base/package.json b/packages/@scope/jsii-calc-base-of-base/package.json
@@ -50,8 +50,6 @@
         }
       },
       "dotnet": {
-        "assemblyOriginatorKeyFile": "keypair.snk",
-        "signAssembly": true,
         "namespace": "Amazon.JSII.Tests.CalculatorNamespace.BaseOfBaseNamespace",
         "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId"
       },

diff --git a/packages/@scope/jsii-calc-base-of-base/test/assembly.jsii b/packages/@scope/jsii-calc-base-of-base/test/assembly.jsii
@@ -30,10 +30,8 @@
   "schema": "jsii/0.10.0",
   "targets": {
     "dotnet": {
-      "assemblyOriginatorKeyFile": "keypair.snk",
       "namespace": "Amazon.JSII.Tests.CalculatorNamespace.BaseOfBaseNamespace",
-      "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId",
-      "signAssembly": true
+      "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId"
     },
     "go": {
       "moduleName": "github.com/aws/jsii/jsii-calc/go"
@@ -163,5 +161,5 @@
     }
   },
   "version": "2.1.1",
-  "fingerprint": "L4CceIu37Nd8GLnVvLXQ62rAZvb7TNHW8E/k4n1CTLI="
+  "fingerprint": "rbtJN11MzD+pqofNrrkTb/GoS1wpG+lpZoOWh+HXysE="
 }
diff --git a/packages/@scope/jsii-calc-base/keypair.snk b/packages/@scope/jsii-calc-base/keypair.snk
diff --git a/packages/@scope/jsii-calc-base/package.json b/packages/@scope/jsii-calc-base/package.json
@@ -66,8 +66,6 @@
         }
       },
       "dotnet": {
-        "assemblyOriginatorKeyFile": "keypair.snk",
-        "signAssembly": true,
         "namespace": "Amazon.JSII.Tests.CalculatorNamespace.BaseNamespace",
         "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BasePackageId"
       },

diff --git a/packages/@scope/jsii-calc-base/test/assembly.jsii b/packages/@scope/jsii-calc-base/test/assembly.jsii
@@ -14,10 +14,8 @@
     "@scope/jsii-calc-base-of-base": {
       "targets": {
         "dotnet": {
-          "assemblyOriginatorKeyFile": "keypair.snk",
           "namespace": "Amazon.JSII.Tests.CalculatorNamespace.BaseOfBaseNamespace",
-          "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId",
-          "signAssembly": true
+          "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BaseOfBasePackageId"
         },
         "go": {
           "moduleName": "github.com/aws/jsii/jsii-calc/go"
@@ -62,10 +60,8 @@
   "schema": "jsii/0.10.0",
   "targets": {
     "dotnet": {
-      "assemblyOriginatorKeyFile": "keypair.snk",
       "namespace": "Amazon.JSII.Tests.CalculatorNamespace.BaseNamespace",
-      "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BasePackageId",
-      "signAssembly": true
+      "packageId": "Amazon.JSII.Tests.CalculatorPackageId.BasePackageId"
     },
     "go": {
       "moduleName": "github.com/aws/jsii/jsii-calc/go",
@@ -206,5 +202,5 @@
     }
   },
   "version": "0.0.0",
-  "fingerprint": "sNbDXkJP4A5egmiid9p5XJ6TF4X3EgfegVxhtaN5Kco="
+  "fingerprint": "rIJAOTzUs2OYke2UCJzexq/fqJOiqmR9PbTMlf37o/A="
 }
diff --git a/packages/@scope/jsii-calc-lib/keypair.snk b/packages/@scope/jsii-calc-lib/keypair.snk
diff --git a/packages/@scope/jsii-calc-lib/package.json b/packages/@scope/jsii-calc-lib/package.json
@@ -61,8 +61,6 @@
         }
       },
       "dotnet": {
-        "assemblyOriginatorKeyFile": "keypair.snk",
-        "signAssembly": true,
         "namespace": "Amazon.JSII.Tests.CalculatorNamespace.LibNamespace",
         "packageId": "Amazon.JSII.Tests.CalculatorPackageId.LibPackageId",
         "versionSuffix": "-devpreview"
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,3 +10,4 @@ dist/ @@
     *.tsbuildinfo
     *.tabl.json
     *.swp
+    *.snk