chore: update integ test tarball to be compatible with ts5.6 #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/feat/ts5.6-benchmark
branch
2 times, most recently
from
b598d1e to
5f9d2df
Compare
sumupitchayan
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1468 was merged despite failing benchmark tests.
This was due to a new TS compiler error on the old code. I've fix this issue by manually updating the offending code in the
aws-cdk-libtarball. Done this so the benchmark will stay comparable for the v5.6 to changes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.