-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add tsc and jsii versions as benchmark metric dimension #1083
Merged
aws-cdk-automation
merged 13 commits into
main
from
sumughan/add-benchmark-metric-dimensions
Jun 17, 2024
Merged
chore: add tsc and jsii versions as benchmark metric dimension #1083
aws-cdk-automation
merged 13 commits into
main
from
sumughan/add-benchmark-metric-dimensions
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
rix0rrr
requested changes
Jun 14, 2024
Signed-off-by: Sumu <[email protected]>
…thub.com/aws/jsii-compiler into sumughan/add-benchmark-metric-dimensions
sumupitchayan
changed the title
chore: add jsii version as benchmark metric dimension
chore: add tsc and jsii versions as benchmark metric dimension
Jun 14, 2024
Signed-off-by: Sumu <[email protected]>
…thub.com/aws/jsii-compiler into sumughan/add-benchmark-metric-dimensions
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
rix0rrr
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishes the
TSC-average
,JSII-average
, andJSII-slowdown
Cloudwatch metrics with the corresponding version numbers as a dimension.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.