fix: stop down-leveling files where only formatting has changed #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a TypeScript-aware normalization on the declarations files to neutralize any formatting discrepancies that may exist between the output of `downlevel-dts` and the output of the raw TypeScript compiler. Also corrects the location of output files in case where `tsc.outDir` is configured (previously a spurious interim path was added).
mrgrain
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a TypeScript-aware normalization on the declarations files to neutralize any formatting discrepancies that may exist between the output of
downlevel-dtsand the output of the raw TypeScript compiler.Also corrects the location of output files in case where
tsc.outDiris configured (previously a spurious interim path was added).Finally, changes how the down-leveled declarations are created when necessary to avoid having to retain all their text in memory, as this can result in a very large amount of data being retained in working set. (Fixes #40)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.