Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #506

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Replace deprecated command with environment file #506

merged 1 commit into from
Jun 22, 2023

Conversation

jongwooo
Copy link
Contributor

Issue #, if available:

Resolve #505

Description of changes:

Update .github/workflows/integration.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "::set-output name=stack-name::$(echo graph-notebook-$RANDOM)"

TO-BE

run: echo "stack-name=$(echo graph-notebook-$RANDOM)" >> $GITHUB_OUTPUT

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin self-requested a review June 22, 2023 22:11
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you @jongwooo !

@michaelnchin michaelnchin merged commit 1461ff1 into aws:main Jun 22, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch June 23, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants