Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom authentication credentials and serializers for Gremlin #356

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #306, #324

Description of changes:

  • Added new "username" and "password" fields to the Gremlin section of %%graph_notebook_config to support custom authentication through Gremlin Server.
  • Added new "message_serializer" field to Gremlin config options. If not specified, GraphSON V3 will be used by default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@triggan triggan self-requested a review October 25, 2022 21:33
triggan
triggan previously approved these changes Oct 25, 2022
Copy link
Contributor

@triggan triggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested against Gremlin Server running with the built-in gremlin-server-secure.yaml configuration. Confirmed that the 3 built-in user accounts work successfully. Also validated the 3 supported serialization formats.

Copy link
Contributor

@triggan triggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnchin michaelnchin merged commit 9090a00 into main Oct 26, 2022
@michaelnchin michaelnchin deleted the gremlin-config-options branch October 26, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants