-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics example notebooks #302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feedback from joywa-github Great tutorial walkthrough of the end-to-end! Some comments: Line 217 - Add a link to "Relating entities through their attributes at query time" Line 332 - Let's define what "different" graph means more than just different. Line 338 - Should we add a line on its use in subsets of graphs or small-medium sized graphs? Line 375 - Is this a repeat of line 26? Maybe just start by defining what strongly linked communities mean. Line 381 - Can we define possible values of components to give the reader an idea? Line 579 - Can we add a little more to the end? A bit abrupt end, or give a more direct comment on the analysis such as, "let's flag this for further investigation." * Update 00-Identifying-Fraud-Rings-Using-Social-Network-Analytics.ipynb
Nice examples of similarity! Some additional comments: Deleted an extra blank cell at the top. Very similar changes as the other notebook. Line 335, please review rephrasing. Line 475, please review rephrasing. Line 526 - at the end of this line, I was not sure what to make of it, until I kept reading. Can we make this more explicit, e.g., "these nodes share a significant number of common features so we need to mark them as similar for further investigation."
Line 375 - Can we define what is an NP-hard problem for someone who isn't familiar with the term? Line 413 - Is it possible to comment on the results of the last problem "minimum distance required to travel to all 150 airports..." so that readers know what to draw from the query?
joywa
previously approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three analytics notebooks showing how to use the AWS Data Wrangler integration with Amazon Neptune
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.