Convert Decimal type results to float for Gremlin #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlawrence
previously approved these changes
Feb 6, 2022
|
We should probably add a change-log entry for this. |
|
Added changelog entry. Tested performance of Gremlin network generation step on ~400 Air Routes results, found negligible (<1ms) difference in average duration between patched and non-patched version, on both Gremlin Server and Neptune. |
charlesivie
added a commit
that referenced
this pull request
Feb 22, 2022
* added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Rename gremlin profile args for clarity (#249) Co-authored-by: Michael Chin <[email protected]> * Add --results-per-page query option (#242) * Add -r option * Replace interval value * Add upper limit Co-authored-by: Michael Chin <[email protected]> * Pin ipython<7.17.0 to patch vulnerability (#250) Co-authored-by: Michael Chin <[email protected]> * Disable root logger output (#248) Co-authored-by: Michael Chin <[email protected]> * Fix OC Bolt metadata (#255) * Fix OC Bolt query metadata output * Add OC metadata tests Co-authored-by: Michael Chin <[email protected]> * Add groupby raw node result option (#253) * Add --group-by-raw query option * Add unit tests Co-authored-by: Michael Chin <[email protected]> * Add Gremlin group-by-depth (#251) * Add --group-by-depth to Gremlin, modify OC with same explicit param * Add tests * PEP8 fixes Co-authored-by: Michael Chin <[email protected]> * addressing comment left in PR #252 related to better conditional statements * Update ChangeLog.md * Suffix all doubles with d. Node batch reduced to 40 (#257) * Suffix all doubles with d. Node batch reduced to 40 * Update changelog for seed file changes * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Michael Chin <[email protected]> * Convert Decimal type results to float for Gremlin (#256) * Convert Decimal type values in GremlinNetwork * replace star import * Revert temp test change * Convert decimal type edge properties * Update Changelog Co-authored-by: Michael Chin <[email protected]> * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded ciritcScore deletes, and moved them into the notebook. * removed hard coded link prediction retractions, and moved them into the notebook. * completed the Getting Started notebook with the pretrained models. * completed the Getting Started notebook with the pretrained models. * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * addressing comment left in PR #252 related to better conditional statements * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded ciritcScore deletes, and moved them into the notebook. * removed hard coded link prediction retractions, and moved them into the notebook. * completed the Getting Started notebook with the pretrained models. * completed the Getting Started notebook with the pretrained models. * tests passing for new SPARQL ML notebooks * Added detail fo new SPARQL/RDF ML notebooks to the change log * fixed bugs in link prediction, amde small improvements after review * updated location of pre-trained models Co-authored-by: Michael Chin <[email protected]> Co-authored-by: Michael Chin <[email protected]> Co-authored-by: Kelvin Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #254
Description of changes:
Decimaltype property values in Gremlin query results would prevent the graph widget from being displayed.GremlinNetworknow ensures that allDecimaltype properties are converted tofloatbefore we attempt to generate the graph widget.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.