Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-for-fluent-bit] Add Replace_Dots option to fluent-bit elasticsearch output #297 #362

Closed
wants to merge 3 commits into from

Conversation

dpujadas
Copy link
Contributor

Issue #297

Description of changes:

Add Replace_Dots option to fluent-bit elasticsearch output

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fawadkhaliq
Copy link

@dpujadas thanks for the PR. can you please increment the chart version to 0.1.7 as 0.1.6 is the current published chart and has been released. If you rebase, circle CI will catch this

@jasonumiker
Copy link
Contributor

I just wanted to +1 this - without this option all my fluent-bits get hung up on something with a dot that is in the cluster by default and stop shipping any logs. So I go and manually edit the configmap after deploying the chart to add this option and it all starts working again. I consider our chart broken unless this option is possible via its values - and agree it should be the default.

@jasonumiker
Copy link
Contributor

#491 - the issue with the failing checks is likely that you merged another PR ahead of this one that 'stole' the version number. I have created a new PR that is this one but incremented the version number again that should be mergable...

@jaypipes
Copy link
Contributor

@dpujadas I added you as Co-authored-by on #362 from @jasonumiker which I was able to resolve conflicts on. This PR can now be closed. Apologies again for the delays and thanks for your patience.

@jaypipes jaypipes closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants