Updating aws-node-termination-handler helm template for prometheus configs #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
reviewed
Jun 17, 2020
|
@bwagner5 I have updated this too to reflect the prometheus flags configuration, let me know if that's ok. Also I'm not sure why CI is failing. |
|
@manute The tests are failing because the chart version was not incremented. I need to sync up some other NTH changes to eks-charts anyways, so I can submit all the changes for the 1.5.0 release in one PR. |
|
We can close this PR since the changes are included in this one: #183 |
|
yeah, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue aws/aws-node-termination-handler#171
PR: aws/aws-node-termination-handler#172
Description of changes:
Updating aws-node-termination-handler helm template for prometheus configs (flag for enabling it and port)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.