Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EFA helm chart #1040

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Added EFA helm chart #1040

merged 1 commit into from
Dec 15, 2023

Conversation

zachdorame
Copy link
Contributor

@zachdorame zachdorame commented Dec 14, 2023

Issue

N/A

Description of changes

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

ran make verify

Results (only for EFA chart):

Validating chart aws-efa-k8s-device-plugin/ w/ helm v3
WARN - Set to ignore missing schemas
PASS - aws-efa-k8s-device-plugin/templates/daemonset.yaml contains a valid DaemonSet (release-name-aws-efa-k8s-device-plugin)
Validating chart aws-efa-k8s-device-plugin/ w/ helm v2
WARN - Set to ignore missing schemas
PASS - aws-efa-k8s-device-plugin/templates/daemonset.yaml contains a valid DaemonSet (release-name-aws-efa-k8s-device-plugin)

Linting chart aws-efa-k8s-device-plugin/ w/ helm v3
==> Linting /Volumes/workplace/eks-charts/stable/aws-efa-k8s-device-plugin/

1 chart(s) linted, 0 chart(s) failed
Linting chart aws-efa-k8s-device-plugin/ w/ helm v2
==> Linting /Volumes/workplace/eks-charts/stable/aws-efa-k8s-device-plugin/
Lint OK

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zachdorame zachdorame requested a review from bwagner5 as a code owner December 14, 2023 21:55
@zachdorame zachdorame requested a review from jdn5126 December 14, 2023 22:32
@zachdorame zachdorame requested a review from jdn5126 December 15, 2023 01:05
@jdn5126 jdn5126 merged commit b626b46 into aws:master Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants