Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-unique license token failures in upgrade from latest side effects tests #9394

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Mar 8, 2025

Description of changes:
This PR fixes the non-unique license token failures in upgrade from latest side effects tests. Before this change, the tests fail with the following error:

Error: validations failed: validating licenseToken is unique for cluster main-i-0612d-53a064b-w-0: license token <license-token-string> is already in use by cluster main-i-0612d-53a064b

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2025
@sp1999
Copy link
Member Author

sp1999 commented Mar 8, 2025

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.46%. Comparing base (8e2c560) to head (451d31b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9394   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files         672      672           
  Lines       49360    49360           
=======================================
  Hits        34286    34286           
  Misses      13288    13288           
  Partials     1786     1786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tatlat
Copy link
Member

tatlat commented Mar 8, 2025

/lgtm

@sp1999 sp1999 force-pushed the fix-side-effects-tests branch from 3b2d331 to 451d31b Compare March 8, 2025 22:31
@tatlat
Copy link
Member

tatlat commented Mar 8, 2025

/lgtm

@sp1999
Copy link
Member Author

sp1999 commented Mar 8, 2025

/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 9a1a0c1 into aws:main Mar 8, 2025
9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9395

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants