-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-unique license token failures in upgrade from latest side effects tests #9394
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9394 +/- ##
=======================================
Coverage 69.46% 69.46%
=======================================
Files 672 672
Lines 49360 49360
=======================================
Hits 34286 34286
Misses 13288 13288
Partials 1786 1786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
3b2d331
to
451d31b
Compare
/lgtm |
/cherry-pick release-0.22 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #9395 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
This PR fixes the non-unique license token failures in upgrade from latest side effects tests. Before this change, the tests fail with the following error:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.