-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting the stage variable in integration tests buildspec files #9333
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.22 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@2ez4szliu: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9333 +/- ##
=======================================
Coverage 69.45% 69.45%
=======================================
Files 672 672
Lines 49357 49357
=======================================
Hits 34283 34283
Misses 13288 13288
Partials 1786 1786 ☔ View full report in Codecov by Sentry. |
@sp1999: new pull request created: #9334 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#2855
Description of changes:
This PR fixes setting the stage variable in integration tests buildspec files for staging pipeline. The staging job was throwing the following error before this change:
This is because of the round brackets around that variable in the buildspec file. The round brackets in bash script makes it a command instead of a variable. Removing the brackets should fix this issue. This PR also updates the buildspec for Nutanix to use the prod license token for staging tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.