Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the stage variable in integration tests buildspec files #9333

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Feb 28, 2025

Issue #, if available:
#2855

Description of changes:
This PR fixes setting the stage variable in integration tests buildspec files for staging pipeline. The staging job was throwing the following error before this change:

/codebuild/output/tmp/script.sh: line 4: CODEBUILD_INITIATOR: command not found

This is because of the round brackets around that variable in the buildspec file. The round brackets in bash script makes it a command instead of a variable. Removing the brackets should fix this issue. This PR also updates the buildspec for Nutanix to use the prod license token for staging tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Feb 28, 2025

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999
Copy link
Member Author

sp1999 commented Feb 28, 2025

/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@2ez4szliu
Copy link
Member

/lgtm
/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@2ez4szliu: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (71a8e1f) to head (ac29065).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9333   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files         672      672           
  Lines       49357    49357           
=======================================
  Hits        34283    34283           
  Misses      13288    13288           
  Partials     1786     1786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit 2faeae8 into aws:main Feb 28, 2025
8 of 9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9334

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants