Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Cilium validation #8492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viktor-kurchenko
Copy link

  • Update docs/content/en/docs/tasks/workload/networking-and-security.md to use Cilium CLI instead of connectivity check YAML manifest.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csplinter for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Hi @viktor-kurchenko. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2024
@viktor-kurchenko
Copy link
Author

@csplinter could you please review?
Thanks!

* Update docs/content/en/docs/tasks/workload/networking-and-security.md
  to use Cilium CLI instead of connectivity check YAML manifest.

Signed-off-by: viktor-kurchenko <[email protected]>
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/cilium/doc/update branch from d4d603e to 33ebf3e Compare August 12, 2024 16:48
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.53%. Comparing base (31c6854) to head (33ebf3e).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8492      +/-   ##
==========================================
+ Coverage   73.49%   73.53%   +0.03%     
==========================================
  Files         578      578              
  Lines       36504    36558      +54     
==========================================
+ Hits        26829    26883      +54     
+ Misses       7956     7955       -1     
- Partials     1719     1720       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude
Copy link
Member

Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate.

@viktor-kurchenko
Copy link
Author

Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate.

I afraid we can't. The manifest https://docs.isovalent.com/v1.10/public/connectivity-check-eksa.yaml already deprecated and functionality moved in the Cilium CLI.

@auriaave
Copy link

auriaave commented Sep 2, 2024

hi 👋 - @mitalipaygude any updates on this? This is the only current supported way of validating the cluster connectivity.

Thank you.

Copy link

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Given that the current instructions suggest to deploy a deprecated YAML that pulls an image with dozens of CVEs, I think that this is in the best interests of eks-anywhere users to leverage actively supported tooling for validating whether the environment is healthy or not.

@eks-distro-bot
Copy link
Collaborator

@joestringer: changing LGTM is restricted to collaborators

In response to this:

LGTM, thanks!

Given that the current instructions suggest to deploy a deprecated YAML that pulls an image with dozens of CVEs, I think that this is in the best interests of eks-anywhere users to leverage actively supported tooling for validating whether the environment is healthy or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants