-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update Cilium validation #8492
base: main
Are you sure you want to change the base?
doc: update Cilium validation #8492
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @viktor-kurchenko. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@csplinter could you please review? |
* Update docs/content/en/docs/tasks/workload/networking-and-security.md to use Cilium CLI instead of connectivity check YAML manifest. Signed-off-by: viktor-kurchenko <[email protected]>
d4d603e
to
33ebf3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8492 +/- ##
==========================================
+ Coverage 73.49% 73.53% +0.03%
==========================================
Files 578 578
Lines 36504 36558 +54
==========================================
+ Hits 26829 26883 +54
+ Misses 7956 7955 -1
- Partials 1719 1720 +1 ☔ View full report in Codecov by Sentry. |
Instead of replacing the current validation steps, we can probably add the Cilium CLI as an alternative way to validate. |
I afraid we can't. The manifest https://docs.isovalent.com/v1.10/public/connectivity-check-eksa.yaml already deprecated and functionality moved in the Cilium CLI. |
hi 👋 - @mitalipaygude any updates on this? This is the only current supported way of validating the cluster connectivity. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Given that the current instructions suggest to deploy a deprecated YAML that pulls an image with dozens of CVEs, I think that this is in the best interests of eks-anywhere users to leverage actively supported tooling for validating whether the environment is healthy or not.
@joestringer: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/content/en/docs/tasks/workload/networking-and-security.md
to use Cilium CLI instead of connectivity check YAML manifest.