Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting cilium daemonset on upgrade workflow to address upgrade issue #2057

Merged
merged 6 commits into from
May 7, 2022

Conversation

maxdrib
Copy link
Contributor

@maxdrib maxdrib commented May 6, 2022

Issue #, if available:
#1888

Description of changes:
This PR restarts the cilium pods in a CloudStack upgrade workflow in order to prevent the issues observed in #1888. We are still waiting to hear what the root cause may be from Isovalent but expect this change to resolve the majority of the issues.

Will create issue to make the logic non CloudStack specific

Testing (if applicable):
Unit tests. Executed the TestCloudStackKubernetes120RedhatTo121Upgrade locally several times and observed the networking issues recover during the upgrade

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2022
@maxdrib maxdrib requested review from jaxesn and jiayiwang7 May 6, 2022 19:36
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #2057 (7418d0f) into main (dc7e82e) will decrease coverage by 0.19%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
- Coverage   49.81%   49.61%   -0.20%     
==========================================
  Files         306      308       +2     
  Lines       25810    25911     +101     
==========================================
  Hits        12856    12856              
- Misses      11632    11734     +102     
+ Partials     1322     1321       -1     
Impacted Files Coverage Δ
pkg/clustermanager/cluster_manager.go 53.50% <57.14%> (+0.03%) ⬆️
pkg/executables/kubectl.go 37.81% <100.00%> (+0.57%) ⬆️
pkg/curatedpackages/curatedpackages.go 26.73% <0.00%> (-35.77%) ⬇️
pkg/curatedpackages/bundle.go 62.19% <0.00%> (-11.72%) ⬇️
pkg/curatedpackages/packageclient.go 76.37% <0.00%> (-0.55%) ⬇️
pkg/manifests/reader.go 50.00% <0.00%> (ø)
pkg/curatedpackages/packagecontrollerclient.go 100.00% <0.00%> (ø)
...l-anywhere/cmd/internal/commands/artifacts/noop.go 0.00% <0.00%> (ø)
pkg/curatedpackages/reader.go 0.00% <0.00%> (ø)
pkg/dependencies/factory.go 49.75% <0.00%> (+0.08%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7e82e...7418d0f. Read the comment docs.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2022
pkg/executables/kubectl.go Outdated Show resolved Hide resolved
pkg/clustermanager/cluster_manager.go Show resolved Hide resolved
}
}

func TestKubectlRetartCiliumDaemonsetSuccess(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the unit tests to not include cilium also right?

@vivek-koppuru
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vivek-koppuru vivek-koppuru merged commit 8d734fa into aws:main May 7, 2022
@maxdrib
Copy link
Contributor Author

maxdrib commented May 9, 2022

/cherrypick release-0.9

@eks-distro-pr-bot
Copy link
Contributor

@maxdrib: new pull request created: #2068

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants