-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restarting cilium daemonset on upgrade workflow to address upgrade issue #2057
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 49.81% 49.61% -0.20%
==========================================
Files 306 308 +2
Lines 25810 25911 +101
==========================================
Hits 12856 12856
- Misses 11632 11734 +102
+ Partials 1322 1321 -1
Continue to review full report at Codecov.
|
pkg/executables/kubectl_test.go
Outdated
} | ||
} | ||
|
||
func TestKubectlRetartCiliumDaemonsetSuccess(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the unit tests to not include cilium also right?
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vivek-koppuru The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.9 |
@maxdrib: new pull request created: #2068 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#1888
Description of changes:
This PR restarts the cilium pods in a CloudStack upgrade workflow in order to prevent the issues observed in #1888. We are still waiting to hear what the root cause may be from Isovalent but expect this change to resolve the majority of the issues.
Will create issue to make the logic non CloudStack specific
Testing (if applicable):
Unit tests. Executed the TestCloudStackKubernetes120RedhatTo121Upgrade locally several times and observed the networking issues recover during the upgrade
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.