-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using pseudo-version for go mod replace #1228
Using pseudo-version for go mod replace #1228
Conversation
@@ -43,7 +43,7 @@ replace ( | |||
github.com/aws/eks-anywhere/release => ./release | |||
github.com/containerd/containerd => github.com/containerd/containerd v1.5.9 | |||
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.0.0 | |||
github.com/docker/distribution => github.com/docker/distribution v2.8.0-beta.1+incompatible | |||
github.com/docker/distribution => github.com/docker/distribution v0.0.0-20220207154021-dcf66392d606 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will Dependabot know this is v2.8.0+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it did give us an option to use a commit or a release tag. So it might have a way to figure it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly not: dependabot/dependabot-core#3017 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe this is just for automatic updates, not sure.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, pokearu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Using the
pseudo-version
of release tagv.2.8.0
for dependencygithub.aaakk.us.kg/docker/distribution
. Hopefully fixes issueTesting:
go mod tidy
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.