Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pseudo-version for go mod replace #1228

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Feb 15, 2022

Description of changes:
Using the pseudo-version of release tag v.2.8.0 for dependency github.com/docker/distribution. Hopefully fixes issue

Testing:
go mod tidy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2022
@@ -43,7 +43,7 @@ replace (
github.com/aws/eks-anywhere/release => ./release
github.com/containerd/containerd => github.com/containerd/containerd v1.5.9
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.0.0
github.com/docker/distribution => github.com/docker/distribution v2.8.0-beta.1+incompatible
github.com/docker/distribution => github.com/docker/distribution v0.0.0-20220207154021-dcf66392d606
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Dependabot know this is v2.8.0+?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it did give us an option to use a commit or a release tag. So it might have a way to figure it out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly not: dependabot/dependabot-core#3017 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this is just for automatic updates, not sure.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,pokearu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 0c04eff into aws:main Feb 16, 2022
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants