Remove promo flag and other dependent flags from the generatebundlefile CLI #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
approved
size/XXL
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR removes the following flags from the generatebundlefile CLI as they are no longer being used anywhere
The regionCheck flag was being used only for non-regional packages release pipelines to verify that the bundles existed in the non-regional supported AWS regions listed here within the AWS Regions table. As we have migrated all the packages build and release pipelines to the regional packages beta account, we don't need this flag anymore.
The promo codebuild job is no longer required to promote the helm charts, bundles and certain images to public ECR as it is now being handled by the ECR Image replication job in all the packages build and release pipelines. So we are removing the promote flag from the CLI. All the remaining flags mentioned above were being used by the promote flag so they are also being removed as a result. Since there is just one account where we handle everything, we don't need any profile variables and so the corresponding publicProfile and privateProfile flags are also being removed.
In addition to that, this PR also removes lot of unused and unnecessary helper functions along with updating any go package dependencies in go.mod file. It also updates a lot of error messages to improve the logs for better debugging. For ex:- removing punctuation or new line characters at the end of the error message, updating error messages to not start with capital letters or "Error" keyword, etc
Testing:
make build