Support private ECR-only bundle generation and promotion #1005
Conversation
eks-distro-bot
added
approved
size/M
abhay-krishna
force-pushed
the
private-ecr
branch
from
4eade36 to
3400cbc
Compare
| @@ -7,6 +7,7 @@ | |||
| "382577505035.dkr.ecr.us-west-2.amazonaws.com": "ecr-login", | |||
| "646717423341.dkr.ecr.us-west-2.amazonaws.com": "ecr-login", | |||
| "783794618700.dkr.ecr.us-west-2.amazonaws.com": "ecr-login", | |||
| "067575901363.dkr.ecr.us-west-2.amazonaws.com": "ecr-login", | |||
There was a problem hiding this comment.
do we need all the other registries added here too?
There was a problem hiding this comment.
Since we're building only to this account, this should suffice. The replication happens outside of this Go code.
|
what does NewBuildMode do? |
Currently we're running builds from the other CDK's build pipelines too, and both share the same repo. Currently the process involves public ECR operations which wouldn't work for the new packages pipelines since they're pushing to regional ECR and not public ECR. So on the packages CDK build projects, we're setting the env var and checking for it here and that helps us perform private ECR-only client creation and operations. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, jonathanmeier5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Support private ECR-only bundle generation and promotion.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.