Allow reconciler retry downloading bundle as the secret may not be in…

…jected immediately (#982)
aws · Sep 14, 2023 · bec1bf5 · bec1bf5
1 parent c308454
commit bec1bf5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/bundle/manager.go b/pkg/bundle/manager.go
@@ -134,7 +134,7 @@ func (m *bundleManager) ProcessBundleController(ctx context.Context, pbc *api.Pa
 				return fmt.Errorf("updating %s status to %s: %s", pbc.Name, pbc.Status.State, err)
 			}
 		}
-		return nil
+		return err
 	}
 
 	allBundles, err := m.bundleClient.GetBundleList(ctx)

diff --git a/pkg/bundle/manager_test.go b/pkg/bundle/manager_test.go
@@ -302,7 +302,7 @@ func TestBundleManager_ProcessBundleController(t *testing.T) {
 
 		err := bm.ProcessBundleController(ctx, pbc)
 
-		assert.NoError(t, err)
+		assert.Error(t, err)
 		assert.Equal(t, api.BundleControllerStateDisconnected, pbc.Status.State)
 	})