Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kube-vip/kube-vip to latest release #3977

Merged

Conversation

eks-distro-pr-bot
Copy link
Contributor

@eks-distro-pr-bot eks-distro-pr-bot commented Nov 1, 2024

This PR bumps kube-vip/kube-vip to the latest Git revision.

Compare changes
Release notes

/hold
/area dependencies

Patch was updated due to k8s client changes introduced in #974 in the v0.8.5 release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Patch application

Failed patch details

Only 0/1 patches were applied!
Patch failed at 0001 use hostname instead of "kubernetes" to contact apiserver
The following files in the above patch did not apply successfully:
pkg/manager/manager.go

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2024
@sp1999
Copy link
Member

sp1999 commented Nov 1, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor Author

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Nov 1, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor Author

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
@sp1999
Copy link
Member

sp1999 commented Nov 1, 2024

/ok-to-test
/lgtm
/approve
/unhold

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a0db9cb into aws:main Nov 1, 2024
3 checks passed
@eks-distro-pr-bot
Copy link
Contributor Author

@sp1999: new pull request created: #3987

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor Author

@sp1999: new pull request created: #3988

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependencies lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants