Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade only the patch versions for cilium on release branch #3724

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 5, 2024

Description of changes:
Project upgrades on release branch was supported in #3275 but it didn't handle getting the latest patch version on release branches for Cilium. Cilium is a special case as the Isovalent team cuts EKS-A specific builds of Cilium which are accessible in our ECR: https://gallery.ecr.aws/isovalent/cilium

Currently, the eks distro PR bot opens PR for Cilium on release branches for the absolute latest version which could also be a minor version upgrade. We only want to update the patch versions for release branches. This PR updates the logic in the upgrade tool to handle this scenario.

Testing:

➜  bin/version-tracker display --project cilium/cilium 
ORGANIZATION  REPOSITORY  CURRENT VERSION  LATEST VERSION   
cilium        cilium      v1.13.18-eksa.1  v1.14.12-eksa.2                                                                /2.7s
➜  BRANCH_NAME=release-0.19 bin/version-tracker display --project cilium/cilium
ORGANIZATION  REPOSITORY  CURRENT VERSION  LATEST VERSION   
cilium        cilium      v1.13.18-eksa.1  v1.13.19-eksa.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2024
@sp1999
Copy link
Member Author

sp1999 commented Sep 5, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Sep 5, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Sep 5, 2024

/approve

@sp1999 sp1999 force-pushed the update-upgrader-tool-for-cilium branch from 7771692 to 072fec6 Compare September 5, 2024 21:51
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,sp1999]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 64f0fff into aws:main Sep 5, 2024
1 check passed
@sp1999 sp1999 deleted the update-upgrader-tool-for-cilium branch September 5, 2024 21:54
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3725

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #3726

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants