cleans up helm chart building and pushing #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
jaxesn
commented
Dec 1, 2023
| @@ -105,7 +105,7 @@ else | |||
| log_file=$(mktemp) | |||
| trap "rm -f $log_file" EXIT | |||
| if ! $CMD $ARGS 2>&1 | tee $log_file; then | |||
| if grep -q "blobs/uploads/\": EOF" $log_file ; then | |||
| if grep -q "blobs/uploads/\": EOF" $log_file || grep -q "blobs/uploads.*404 Not Found" $log_file; then | |||
There was a problem hiding this comment.
i think the error changed slightly on ecr-public, so just added this in.
jaxesn
force-pushed
the
jgw/cleanup-helm-more
branch
from
e8372b1 to
5bee9f9
Compare
eks-distro-bot
added
size/XS
eks-distro-bot
added
size/L
|
/LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This is a further attempt at cleaning up the helm building process. This removes (almost) all the ecr/public specific logic in favor of using skopeo where possible to support any registry, including local ones.
This simplifies the logic when looking for images down:
latesttag to try and find it vs the specific tag, since those images would have been built previous and have different specific tags.latest, it will use the aws cli to find another tag associated with that image to be used in the helm chart. i honestly dont know the significance here, but this is how its always been so there must be a decent reasonWhen pushing the final chart, it used to use the aws cli to add a second tag to the helm chart in ecr, this is changed to use skopeo copy instead to be more generic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.