standardize batch builds for archd images #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
size/XS
jaxesn
force-pushed
the
jgw/testing-qemu
branch
from
dae29b4 to
b9f84ae
Compare
eks-distro-bot
added
size/L
jaxesn
force-pushed
the
jgw/testing-qemu
branch
10 times, most recently
from
1551bbf to
fd0a566
Compare
jaxesn
force-pushed
the
jgw/testing-qemu
branch
from
fd0a566 to
4f0d2a3
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We had two projects, harbor and emissary, which we had broken out into a batch build by image platform due to how long they took to build on a single host. The reason they took so long is when building images that do more than just COPY can take quiet away when running for the arch that does not match the host, due to the virtualization through qemu.
So far I had just hand made the batch buildspecs for these two projects. We just added the upgrader project which started to segfault in CI due to qemu when building the amd image on our arm host. I think we could downgrade qemu to 6.x from 7.x, 6.x appears to be more stable, however probably the safest thing to do is run these image builds on a matching host arch.
We ran into this same thing in eks-d where we build the minimal images in prow and ended up doing the same thing.
This PR adds the automation needed to make generating the build specs by image platform easier.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.