fix(cli): project delete empty s3 buckets before deleting #714
Conversation
iamhopaul123
requested review from
kohidave,
efekarakus,
bvtujo,
SoManyHs and
a team
iamhopaul123
force-pushed
the
project-delete/empty-s3-buckets
branch
from
c8514cc to
e0bcecb
Compare
iamhopaul123
force-pushed
the
project-delete/empty-s3-buckets
branch
from
e0bcecb to
c221c19
Compare
| @@ -52,3 +60,46 @@ func (s *Service) PutArtifact(bucket, fileName string, data io.Reader) (string, | |||
|
|
|||
| return resp.Location, nil | |||
| } | |||
|
|
|||
| // EmptyBucket deletes all objects within the bucket. | |||
| func (s *Service) EmptyBucket(bucket string) error { | |||
There was a problem hiding this comment.
Looks tricky, thanks for tackling this.
Have you looked at using the BatchDelete of the s3Manager?
Here's a blog post on how it might help simplify things.
There was a problem hiding this comment.
Tried that method before. Ugh it is helpful when using non-versioning bucket. However, when it comes to "versioning bucket", things can be very complicated and "s3manager" they don't support versioning bucket very well, and BatchDelete cannot delete all the other versioning for the objects nor the "delete marker" for that.
Had a discussion with Efe yesterday on those resolved comments above on that.
There was a problem hiding this comment.
lol no problem!
@iamhopaul123 this looks so much neater and also correct :P thanks for looking into it
iamhopaul123
force-pushed
the
project-delete/empty-s3-buckets
branch
from
c221c19 to
db50373
Compare
| _, err = s.s3Svc.DeleteObjects(&s3.DeleteObjectsInput{ | ||
| Bucket: aws.String(bucket), | ||
| Delete: &s3.Delete{ | ||
| Objects: objectsToDelete, |
There was a problem hiding this comment.
listResp.DeleteMarkers + listResp.Versions can not be more than 1000 objects right?
There was a problem hiding this comment.
Yeah but objectsToDelete shall not exceed 1000 either, because the list return values limit already includes both version and delete marker
| @@ -52,3 +60,46 @@ func (s *Service) PutArtifact(bucket, fileName string, data io.Reader) (string, | |||
|
|
|||
| return resp.Location, nil | |||
| } | |||
|
|
|||
| // EmptyBucket deletes all objects within the bucket. | |||
| func (s *Service) EmptyBucket(bucket string) error { | |||
There was a problem hiding this comment.
lol no problem!
@iamhopaul123 this looks so much neater and also correct :P thanks for looking into it
| @@ -143,3 +143,7 @@ type wsProjectManager interface { | |||
| type artifactPutter interface { | |||
| PutArtifact(bucket, fileName string, data io.Reader) (string, error) | |||
| } | |||
|
|
|||
| type bucketEmptier interface { | |||
iamhopaul123
force-pushed
the
project-delete/empty-s3-buckets
branch
from
db50373 to
d2e595a
Compare
fix #700, with minor refactoring.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.