fix: correctly empty repos when deleting app regional resources #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍕 Here are the new binary sizes!
|
efekarakus
approved these changes
Jan 18, 2024
Co-authored-by: Efe Karakus <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5617 +/- ##
============================================
- Coverage 70.03% 70.02% -0.02%
============================================
Files 303 303
Lines 46589 46592 +3
Branches 299 299
============================================
- Hits 32629 32625 -4
- Misses 12377 12382 +5
- Partials 1583 1585 +2 ☔ View full report in Codecov by Sentry. |
efekarakus
reviewed
Jan 18, 2024
| ecr := cf.regionalECRClient(region) | ||
| for repo := range resources.RepositoryURLs { | ||
| if err := ecr.ClearRepository(repo); err != nil { | ||
| for svcName, _ := range resources.RepositoryURLs { |
There was a problem hiding this comment.
rip sorry for the churn :'( static check says my suggestion is stoopid
There was a problem hiding this comment.
Yeah but for svcName := range resources.RepositoryURLs { def. made me churn too...
iamhopaul123
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.