chore: fix allow only CFN-ready values for `task run` flags; change logging logic #2904

huanjani · 2021-10-08T17:35:32Z

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

https://github.com/aws/copilot-cli/security/dependabot/cf-custom-resources/package-lock.json/path-parse/open  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds a "deployed SNS topic" selector to the `select` package and some data structures to accompany it. Uses the `deploy store` under the hood and relies on resource group tagging API, so it can only be used on one environment at a time.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…behaviors (aws#2738) This PR is part of the second step (writing units test) to address aws#2492. It: 1. Upgrades `mergo` 2. Fixes code by implementing custom transformers so that all `applyEnv` tests that have been passing are still passing Next: 1. Change pointer struct to struct and remove `pStruct` transformers 2. Fix bugs (tests that have been failing and commented out in previous PRs (aws#2700 ~ aws#2734) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.4.2 to 0.5.0. - [Release notes](https://github.com/golang/mod/releases) - [Commits](golang/mod@v0.4.2...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.17 to 1.40.22. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.17...v1.40.22) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Continued from aws#2703. Refactor described [here](https://github.com/aws/copilot-cli/pull/2703/files#r683800143) to be implemented in a future PR.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Part of aws#2588.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add `--force` flag for `svc deploy` and `deploy`, allowing users to force deploy their ECS service. Fixes aws#2597. E2E test and doc will be added in an upcoming PR.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

As mentioned in aws#2744, refactors describer structs to remove redundancy.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ws#2750)  Part of aws#2588  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Subsumes aws#2704. Also refactors SNS selector to a single prompt, where we only ask the customer to select topics that are deployed across all existing environments.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR This PR is part of the second step (writing units test) to address aws#2492. It: 1. Fix previously found `ApplyEnv` bugs by implementing transformers needed 2. Refactor `transform.go` Previous: aws#2738 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…s#2757) Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey) from 2.2.16 to 2.3.0. - [Release notes](https://github.com/AlecAivazis/survey/releases) - [Commits](AlecAivazis/survey@v2.2.16...v2.3.0) --- updated-dependencies: - dependency-name: github.com/AlecAivazis/survey/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.22 to 1.40.27. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.22...v1.40.27) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Adds the --yes flag to `copilot svc exec` docs.  Fixes aws#2760 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ule (aws#2756) This PR: 1. unmarshal/marshal CFN template to/from YAML nodes. 2. parse node from rule. 3. add a unit test for the exported function `CloudformationTemplate`. Part of aws#2588 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Addressing: aws#2756 (comment) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…2767) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Part of aws#2588. Work on the basis of aws#2756.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

`FIFOOrBool` is a composite field and need custom merge logic. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ws#2770) Previously, any non-App Runner service threw out the log statement about the platform field in the manifest. Now, this happens only when the platform has been redirected _and_ a non-App Runner service has been created. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

)   By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Part of aws#2588.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…nifest (aws#2775) ⚰️ By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…straight to CFN

…cted

internal/pkg/cli/svc_init.go

internal/pkg/cli/job_init.go

efekarakus

Looks great! just small suggestions

internal/pkg/cli/job_init.go

internal/pkg/cli/svc_init.go

efekarakus · 2021-10-11T22:09:20Z

internal/pkg/task/task.go

+func ValidOSs() []string {
+	return []string{osWindowsServer2019Core, osWindowsServer2019Full, osLinux}
+}
+
+// ValidArchs returns all valid CFN-friendly architectures.
+func ValidArchs() []string {


is there a reason why you prefered functions instead of exporting variables? I think this is neat it allows the values to be immutable 👍

internal/pkg/cli/task_run.go

…rately

efekarakus

Looks good! Just a tiny log request

efekarakus · 2021-10-12T20:38:48Z

internal/pkg/cli/svc_init.go

-	}
-	if o.wkldType != manifest.RequestDrivenWebServiceType {
-		log.Warning("See 'platform' field in your manifest.\n")
+		log.Warningf("Your architecture type %s is currently unsupported. Setting platform %s instead.\n", color.HighlightCode(detectedArch), redirectedPlatform)


should this be consistent with job init?

No, because job init doesn't have to weed out RDWS.

iamhopaul123 and others added 30 commits August 12, 2021 23:19

chore: group segments into a pathSegment struct (aws#2764)

cd567b0

Addressing: aws#2756 (comment) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

build: upgrade e2e/Dockerfile go version to 1.16.6 from 1.13.15 (aws#…

83ae7e1

…2767) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: implement the transformer for FIFOOrBool (aws#2768)

807cee2

`FIFOOrBool` is a composite field and need custom merge logic. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: update help text to include Woker Service on init cmds (aws#2771)

46f70f0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: add metadata to queue resources (aws#2773)

188efbd

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: remove fifo field from queue settings in the Worker Service ma…

a810d57

…nifest (aws#2775) ⚰️ By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: add progress tracker metadata to sns resources (aws#2774)

d3f49ae

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chore: update manifest env var to COPILOT_QUEUE_URI (aws#2779)

19f1b42

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

huanjani added 5 commits September 17, 2021 14:16

Merge remote-tracking branch 'archer/feat/pencere' into feat/pencere

eece512

fix: narrow acceptible OS and Arch options because task run flags go …

bc0b571

…straight to CFN

fix: change from array of RuntimePlatform objects to one object

a50cf52

chore: log platform manifest msg for all non-default, not just redire…

d4f148f

…cted

chore: change job and svc logging

9126d24

huanjani requested a review from a team as a code owner October 8, 2021 17:35

huanjani requested review from Lou1415926 and removed request for a team October 8, 2021 17:35

amazon-ecs-cli-v2-pr-manager requested a review from iamhopaul123 October 8, 2021 17:35

huanjani added 5 commits October 8, 2021 10:44

Merge remote-tracking branch 'archer/feat/pencere' into task-run-fixes

6dcee86

fix: add linux as valid OS

7efffb8

fix: tweak unit test

2b2f1d9

fix: for real this time

d6926e8

fix: change platform for CFN Windows OS formats

eb51e2f

huanjani commented Oct 9, 2021

View reviewed changes

internal/pkg/cli/svc_init.go Outdated Show resolved Hide resolved

huanjani added 3 commits October 8, 2021 17:32

chore: disable exec for windows tasks

896a56c

chore: add enableExec to unit test

99a8966

chore: add example of task run

fbd8c3f

iamhopaul123 reviewed Oct 11, 2021

View reviewed changes

internal/pkg/cli/job_init.go Outdated Show resolved Hide resolved

internal/pkg/cli/job_init.go Outdated Show resolved Hide resolved

huanjani added 2 commits October 11, 2021 12:31

chore: remove repetitive code

d3d89f7

chore: rename var

60e00d9

efekarakus reviewed Oct 11, 2021

View reviewed changes

chore: change log statements, validate full platform not os/arch sepa…

89e31ea

…rately

efekarakus changed the title ~~fix: allow only CFN-ready values for task run flags; change logging logic~~ chore: fix allow only CFN-ready values for task run flags; change logging logic Oct 12, 2021

efekarakus approved these changes Oct 12, 2021

View reviewed changes

iamhopaul123 approved these changes Oct 12, 2021

View reviewed changes

huanjani merged commit 320f3e0 into aws:feat/pencere Oct 12, 2021

huanjani deleted the task-run-fixes branch October 27, 2021 00:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix allow only CFN-ready values for `task run` flags; change logging logic #2904

chore: fix allow only CFN-ready values for `task run` flags; change logging logic #2904

huanjani commented Oct 8, 2021

efekarakus left a comment

efekarakus Oct 11, 2021

efekarakus left a comment

efekarakus Oct 12, 2021

huanjani Oct 12, 2021

chore: fix allow only CFN-ready values for task run flags; change logging logic #2904

chore: fix allow only CFN-ready values for task run flags; change logging logic #2904

Conversation

huanjani commented Oct 8, 2021

efekarakus left a comment

Choose a reason for hiding this comment

efekarakus Oct 11, 2021

Choose a reason for hiding this comment

efekarakus left a comment

Choose a reason for hiding this comment

efekarakus Oct 12, 2021

Choose a reason for hiding this comment

huanjani Oct 12, 2021

Choose a reason for hiding this comment

chore: fix allow only CFN-ready values for `task run` flags; change logging logic #2904

chore: fix allow only CFN-ready values for `task run` flags; change logging logic #2904