fix(cli)!: use default creds when deploying "test" env with "copilot init" #1242
+35
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
requested review from
a team and
kohidave
and removed request for
a team
efekarakus
changed the title
iamhopaul123
approved these changes
Aug 10, 2020
internal/pkg/cli/init.go
Outdated
| IsProduction: false, | ||
|
|
||
| TempCreds: tempCredsVars{ |
There was a problem hiding this comment.
Are this temp cred only configurable via copilot init? (Can users specify them using flags when doing env init?)
There was a problem hiding this comment.
Jes, next PR will add the flags so that users can configure them via flags in env init.
efekarakus
force-pushed
the
init/use-default-creds
branch
from
e970f95 to
81ed939
Compare
kohidave
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the --profile flag from the "init" command as
it's most likely not used + this change is the expected behavior from
customers.
Fixes #1068 #1104
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.