Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): set SharedConfigEnable for DefaultWithRegion #1205

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

efekarakus
Copy link
Contributor

@efekarakus efekarakus commented Jul 28, 2020

Setting SharedConfigState to SharedConfigEnable allows the AWS SDK to
load the shared config file (~/.aws/config). Previously, we were
ignoring the config file for the "DefaultWithRegion" method hence why it
wouldn't pick up the credentials_process field in the file.

Fixes #808 #1151

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Setting SharedConfigState to SharedConfigEnable allows the AWS SDK to
load the shared config file (~/.aws/config). Previously, we were
ignoring the config file for the "DefaultWithRegion" method hence why it
wouldn't pick up the credentials_process field in the file.

Fixes aws#808
Copy link
Contributor

@kohidave kohidave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@mergify mergify bot merged commit c7b9cb8 into aws:master Jul 29, 2020
@efekarakus efekarakus deleted the fix-808 branch July 29, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs when using a profile with a credential process
3 participants