-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifest): allow additional docker build overrides in manifest #1059
Merged
+833
−226
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
f740e81
Add context field to mft
bvtujo add851a
update mft comments
bvtujo 637dccd
Add comments to Context() and context to testdata
bvtujo 5ef0e0a
fix unit test expectations for context
bvtujo fb58231
feat(workspace): add CopilotDirPath as public function
bvtujo ec1e5fd
Add mocking for UnmarshalService and combine dockerfile path and cont…
bvtujo 0689c6a
move Dockerfile() and Context() functions to svc package since they a…
bvtujo c07791a
chore(manifest): add custom YAML unmarshaler for docker build args
bvtujo 19f8380
chore(cli): update manifest & service deploy tests
bvtujo c5c0956
chore(templates): update buildspec to parse context, args, dockerfiles
bvtujo d0799b2
add build args struct to docker
bvtujo 1ad4212
chore(docker): refactor Build to take a struct instead of args
bvtujo 597cab4
Fix svc deploy test syntax
bvtujo 509b21c
fix bad method signatures
bvtujo 2d910d0
rename ARGS to build_args in buildspec
bvtujo a3c3862
Rename Build input arg to in
bvtujo 185923f
remove dockerParams struct and directly pass in docker.BuildArguments
bvtujo 22e3681
fix typo in Dockerfile() comment
bvtujo 823c77e
Add comments describing BuildArguments fields
bvtujo ca0bf23
Streamline logic checking for Context field.
bvtujo 054f503
Fix commit error from GH and reword docker tests
bvtujo 8a385f5
Convert BuildArgs to pointer for checking
bvtujo 719e9cf
Add unit tests for UnmarshalYAML
bvtujo 34d84db
add descriptive error and fix error case test
bvtujo 3ed58cd
Refactor build argument logic to package manifest
bvtujo da4964c
rename test function for CopilotDirPath tests
bvtujo ac2ec31
allow svc.Build() to infer Dockerfile name
bvtujo 6e63e42
add fixes to buildspec commands and echo statements
bvtujo 6cccd75
Revert to old default for manifests
bvtujo 85bd6a0
Merge branch 'master' into mft-context
bvtujo ef7feb5
Fix buildspec to remove extra spaces
bvtujo 2139b32
Update repository package to take docker.BuildArguments
bvtujo f9cb57e
Update docker test cases to not use imageName()
bvtujo a247546
Update interfaces to take docker.BuildArguments
bvtujo 129beb8
implement new docker args signature
bvtujo 7b38a38
go mod tidy
bvtujo f97d542
Implement new docker args in task run
bvtujo 6bb3a15
rename Build to BuildArgs in package manifest
bvtujo 79dc17e
Fix test data to reflect prior default
bvtujo 1cb5473
add sorting logic to build-arg parser for test stability
bvtujo f83de96
Use guard clauses, not else ifs, in svc.go
bvtujo 39befaf
Comment to indicate successful unmarshaling
bvtujo b9b78ff
Remove unnecessary else clause in svc.go
bvtujo 5d6e755
whitespace fixes
bvtujo 4d5861f
fix unjoined context and dockerfile paths in guard clauses
bvtujo bcf19a8
Merge branch 'master' into mft-context
bvtujo 951e132
remove test case to match master
bvtujo d0ea656
Merge branch 'master' into mft-context
bvtujo b500b6c
refactor svc package to return manifest.DockerBuildArgs and svcDeploy…
bvtujo 80eaa2a
Edit comment in manifests
bvtujo d6aaa98
Update testdata to reflect manifest comment
bvtujo 5c35c8b
Remove dependency on aws in svc deploy
bvtujo 6424529
Merge branch 'master' into mft-context
bvtujo b22b186
Fix tests in repository to handle new Build() signature
bvtujo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add build args struct to docker
commit d0799b243aaf925893f527d4bcec22f67fc9052e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v nice comments!