Use the Dockerfile rel path against Copilot dir instead of pwd #1030
Labels
type/bug
Issues that are bugs.
Comments
|
Related #1059 |
|
Just to clarify, do you suggest that the path specified in the manifest for the top-level Dockerfile in your example should be |
|
ah no since the fluentbit dockerfile is just a sidecar. So far we don't do the upload for their sidecar image automatically. It's just i would expect |
mergify bot
pushed a commit
that referenced
this issue
Aug 5, 2020
…ifest (#1059) This PR adds the ability to specify [docker compose style build directives](https://docs.docker.com/compose/compose-file/#build) in the manifest. For example, customers can now specify `dockerfile`, `context`, and `args` underneath the `build` key in the manifest, or simply specify a dockerfile path at `build`. #### Example 1 ```yaml image: build: path/to/MyDockerfile ``` This manifest will build the dockerfile specified at `build`, using the directory `path/to` as the build context. #### Example 2 ```yaml image: build: dockerfile: path/to/MyDockerfile context: path/to/service/code args: ABC: 123 arg2: value2 ``` This example will build the dockerfile at `path/to/MyDockerfile` using the directory `path/to/service/code` as the build context and passing the args as `--build-arg` flags. Fixes #822 and #1030 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now we default the Dockerfile path to be
./Dockerfile. As expected.should be the path for Copilot dir instead ofpwd. However, if I have an app like this:Then if I run
svc deployinfluentbit/, then Copilot will pick up the Dockerfile for fluentbit instead of the Dockerfile in the root dir, which can be considered as a bug.The text was updated successfully, but these errors were encountered: