Fix deprecation warnings related to asyncio #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
DeprecationWarning: 'loop' fixture is deprecated and scheduled for
removal, please use 'event_loop' instead
Except for `ext-aiohttp` because `pytest-aiohttp < 1.0.0` is too old
for that.
Fixes
The loop argument is deprecated since Python 3.8, and scheduled
for removal in Python 3.10.
See https://docs.python.org/3.8/library/asyncio-task.html#asyncio.sleep
and https://docs.python.org/3.8/library/asyncio-task.html#asyncio.wait
Fixes
The explicit passing of coroutine objects to asyncio.wait() is
deprecated since Python 3.8, and scheduled for removal in Python
3.11.
This has been “deprecated as it leads to confusing behavior”. See
https://docs.python.org/3.8/library/asyncio-task.html#asyncio-example-wait-coroutine
and
https://stackoverflow.com/questions/69889075/asyncio-wait-confusion-when-passed-a-coroutine
Use fixture `aiohttp_client` instead of `test_client`. All the tests back to Python 3.5 complained that `test_client` was deprecated.
wangzlei
approved these changes
Nov 7, 2022
|
Any change of getting that merged? I'd like to contribute more changes towards running the tests against Python 3.10 and 3.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
ext-aiohttptests can use the fixtureevent_loopinstead ofloopas well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.