Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Coverage report is combined together #297

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix: ensure Coverage report is combined together #297

merged 1 commit into from
Apr 28, 2021

Conversation

antdking
Copy link
Contributor

*Issue #296

Description of changes:

Run coverage in Append mode, so that we build a full coverage report for codecov

fixes: #296


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Run coverage in Append mode, so that we build a full coverage report for codecov

fixes: #296
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #297 (d6e7938) into master (d807884) will increase coverage by 47.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #297       +/-   ##
===========================================
+ Coverage   32.04%   79.81%   +47.77%     
===========================================
  Files          84       84               
  Lines        3305     3305               
===========================================
+ Hits         1059     2638     +1579     
+ Misses       2246      667     -1579     
Impacted Files Coverage Δ
aws_xray_sdk/core/sampling/local/sampling_rule.py 94.44% <0.00%> (+11.11%) ⬆️
aws_xray_sdk/core/sampling/sampler.py 64.00% <0.00%> (+14.66%) ⬆️
aws_xray_sdk/sdk_config.py 93.10% <0.00%> (+24.13%) ⬆️
aws_xray_sdk/core/context.py 87.87% <0.00%> (+24.24%) ⬆️
aws_xray_sdk/core/recorder.py 87.45% <0.00%> (+26.44%) ⬆️
aws_xray_sdk/core/sampling/reservoir.py 59.25% <0.00%> (+27.77%) ⬆️
aws_xray_sdk/core/models/facade_segment.py 84.61% <0.00%> (+30.76%) ⬆️
aws_xray_sdk/core/daemon_config.py 97.95% <0.00%> (+32.65%) ⬆️
aws_xray_sdk/core/models/segment.py 97.14% <0.00%> (+34.28%) ⬆️
aws_xray_sdk/core/models/noop_traceid.py 100.00% <0.00%> (+37.50%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d807884...d6e7938. Read the comment docs.

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srprash srprash merged commit 414313a into aws:master Apr 28, 2021
Hargrav3s pushed a commit to Gavant/aws-xray-sdk-python that referenced this pull request Mar 22, 2022
Run coverage in Append mode, so that we build a full coverage report for codecov

fixes: aws#296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage depending on the order of tests run
3 participants