no op trace id generation #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 79.63% 79.81% +0.17%
==========================================
Files 83 84 +1
Lines 3276 3295 +19
==========================================
+ Hits 2609 2630 +21
+ Misses 667 665 -2
Continue to review full report at Codecov.
|
willarmiros
approved these changes
Apr 27, 2021
Hargrav3s
pushed a commit
to Gavant/aws-xray-sdk-python
that referenced
this pull request
Mar 22, 2022
* no op trace id generation * added clean up in tests and minor changes * modified typo * added checking false only conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By merging this PR X-Ray Python SDK will generate no op trace and entity id for upsampled requests and secure random id for sample requests. However, customer can choose to generate secure random trace and entity ids for all the requests by setting
AWS_XRAY_NOOP_IDenvironment variable asFalse.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.