Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run integration tests on master. #277

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

anuraaga
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@anuraaga anuraaga requested review from bhautikpip and srprash March 19, 2021 05:45
@anuraaga
Copy link
Contributor Author

This pr obviously doesn't change build logic so something seems to have made the build red, guessing unpinned dependencies. @srprash @lupengamzn is it something you could look at?

@awssandra
Copy link

Can we also change the branch name to "main"? Remove non-inclusive wording if you see it :)

@anuraaga
Copy link
Contributor Author

Github has added support for renaming relatively smoothly, including migrating open PRs, it's just the workflows that may need to be updated. It's probably a good time to go ahead and do it for all our repos indeed.

@srprash
Copy link
Contributor

srprash commented Mar 19, 2021

This pr obviously doesn't change build logic so something seems to have made the build red, guessing unpinned dependencies. @srprash @lupengamzn is it something you could look at?

SQLAlchemy tests are failing due to some changes in the latest version of the library. We would need to pin its version for some of the python version tests. @lupengamzn is taking a look.

@lupengamzn
Copy link
Contributor

This pr obviously doesn't change build logic so something seems to have made the build red, guessing unpinned dependencies. @srprash @lupengamzn is it something you could look at?

The issue should be fixed now by pinning the version of SQLAlchemy and Flask-SQLAlchemy for test.

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #277 (db6d0ad) into master (266bc82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          83       83           
  Lines        3277     3277           
=======================================
  Hits         2608     2608           
  Misses        669      669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266bc82...db6d0ad. Read the comment docs.

@anuraaga anuraaga merged commit f5f41fb into aws:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants