[iss-167] X-RAY creates new session #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 7, 2019 15:43
…ersion before `signature_version=UNSIGNED`
…ersion before `signature_version=UNSIGNED`
…ersion before `signature_version=UNSIGNED`
|
tests fail due to #179 or more preciselly to say boto/botocore#1829 |
|
PR #179 is merged; tests pass. Rebasing current PR |
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 83.4% 83.33% -0.07%
==========================================
Files 77 77
Lines 2910 2910
==========================================
- Hits 2427 2425 -2
- Misses 483 485 +2
Continue to review full report at Codecov.
|
…ersion before `signature_version=UNSIGNED`
…ersion before `signature_version=UNSIGNED`
…on' of https://github.com/polamayster/aws-xray-sdk-python into issue-167-X-RAY-creates-new-session-with-hardcoded-region
chanchiem
approved these changes
Nov 21, 2019
|
@chanchiem thanks a lot for a collaboration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #167 *
Description of changes:
Added empty AWS credentials for botocore versions before
signature_version=UNSIGNEDto prevent unnecessary/redundant credentials retrieval (IAM role) as they actually are not needed for a x-ray client.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.