Correctly remove password component from SQLAlchemy URLs, preventing … #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid characters in SQLAlchemy subsegment names
|
Thank you very much for your contribution! This looks good to me. Very nice find :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…invalid characters in SQLAlchemy subsegment names
Issue #: #131
Description of changes:
The URL is parsed and the password stripped, but the old URL is assigned to
safe_url. The methodParseResult._replacereturns a newParseResultbut does not modify the initialParseResult. This fixes the problem I described in the issue linked above where SQLAlchemy will replace the password component of SQLAlchemy URL with***which is then used as a Xray subsegment name, despite being invalid characters.This is not a new feature, but a small fix to existing code which seems intended to do this in the first place. It seems the sort of thing which should require a test, but I'm not really sure how to add one that tests this since all the tests I can see use
sqlite:///:memory:which as far as I know cannot have a password.When I run the tests locally before this patch I have 5 failures in
tests/test_patcher.py, when running after this patch, I get the same 5 failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.